This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
metadata server: redirect security-credentials when no trailing slash #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* aws metadata api uses a permanent redirect so we use the same
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
+ Coverage 37.42% 37.91% +0.49%
==========================================
Files 21 21
Lines 799 807 +8
==========================================
+ Hits 299 306 +7
Misses 472 472
- Partials 28 29 +1
|
|
@uswitch/cloud could someone review please |
samb1729
approved these changes
Jul 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #116: canonical redirect.
Previously we served on both:
/{version}/meta-data/iam/security-credentials//{version}/meta-data/iam/security-credentialsThis changes so that the latter is redirected to the former.