-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site: Added file input accessibility test page #2963
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working this @RachelCorsino. Added some comments below and tagged who I thought would be the best to respond to each item. Let me know if you have questions!
Wondering if we have an extra "and" on the verbiage for test 1.4.1 Otherwise looks good! |
After discussing this with @amycole501 and @alex-hull, we decided to move forward with the following plan:
@amycole501 and @alex-hull, let me know if I missed anything here. |
…wds-site into rc-file-input-checklist
@amycole501 I agree it sounds weird and seems like there's an extra "and". How is this supposed to read?
|
@RachelCorsino I like the first sentence better for 1.4.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved convo about suggested change that we're not doing at this time. Looks good to me otherwise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some additional suggestions for review. We can discuss these in our call in a few minutes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks team for all the discussion on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Summary
Added accessibility test page for file input component
Important
We need to update the changelog dates before merge
Related issue
Closes #2877
Preview link
File Input Component Page
File Input Accessibility Tests Page
Testing and review
Follow these steps: