Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site: Added file input accessibility test page #2963

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

RachelCorsino
Copy link
Contributor

@RachelCorsino RachelCorsino commented Nov 12, 2024

Summary

Added accessibility test page for file input component

Important

We need to update the changelog dates before merge

Related issue

Closes #2877

Preview link

File Input Component Page
File Input Accessibility Tests Page

Testing and review

Follow these steps:

  1. Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
  2. Confirm that the main component page links to the accessibility tests page in the side navigation.
  3. Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.
  4. Confirm that the main component page shows the accessibility tests summary.
  5. Check that accessibility tests page provides the correct counts for each test status type.
  6. Confirm the test checklist summaries and data are accurate.
  7. Confirm no visual issues.
  8. Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.

@RachelCorsino RachelCorsino marked this pull request as ready for review November 14, 2024 15:19
@RachelCorsino RachelCorsino requested a review from a team as a code owner November 14, 2024 15:19
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working this @RachelCorsino. Added some comments below and tagged who I thought would be the best to respond to each item. Let me know if you have questions!

_components/file-input/file-input.md Outdated Show resolved Hide resolved
_data/accessibility-tests/file-input.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/file-input.yml Outdated Show resolved Hide resolved
_includes/accessibility-tests/wcag-details.html Outdated Show resolved Hide resolved
_data/accessibility-tests/file-input.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/file-input.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/file-input.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/file-input.yml Outdated Show resolved Hide resolved
_includes/accessibility-tests/wcag-details.html Outdated Show resolved Hide resolved
_includes/accessibility-tests/wcag-details.html Outdated Show resolved Hide resolved
@amycole501
Copy link

Wondering if we have an extra "and" on the verbiage for test 1.4.1

Otherwise looks good!

@amyleadem
Copy link
Contributor

After discussing this with @amycole501 and @alex-hull, we decided to move forward with the following plan:

  • Update the 3.3.1 status to pass and update the summary. The criterion is actually scoped to only require a detailed error message in visual text form on the page. 3.3.1 does not require it to be read out via screen reader. Instead, the screen reader portion of that is captured in 1.3.1 (details in the next bullet point)
  • Update the 1.3.1 status to pass with exceptions and update the summary to include a note about error messages. @amycole501 helpfully summarized to criteria to mean "what you see on the page is what you hear".
  • Remove the 4.1.3 checklist item from the page at this time. It is a WCAG 2.2 requirement that we will incorporate in future re-tests of the component.

@amycole501 and @alex-hull, let me know if I missed anything here.

@RachelCorsino
Copy link
Contributor Author

Wondering if we have an extra "and" on the verbiage for test 1.4.1

Otherwise looks good!

@amycole501 I agree it sounds weird and seems like there's an extra "and". How is this supposed to read?

  1. When you view the file input component, focus indicators, text labels, field descriptions and messaging all help establish meaning.
    or (this probably doesn't follow the way we word things but...)
  2. Focus indicators, text labels, and field descriptions and messaging all help establish meaning when you view the file input component.

@amycole501
Copy link

Wondering if we have an extra "and" on the verbiage for test 1.4.1
Otherwise looks good!

@amycole501 I agree it sounds weird and seems like there's an extra "and". How is this supposed to read?

  1. When you view the file input component, focus indicators, text labels, field descriptions and messaging all help establish meaning.
    or (this probably doesn't follow the way we word things but...)
  2. Focus indicators, text labels, and field descriptions and messaging all help establish meaning when you view the file input component.

@RachelCorsino I like the first sentence better for 1.4.1

finekatie
finekatie previously approved these changes Nov 15, 2024
Copy link
Contributor

@finekatie finekatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved convo about suggested change that we're not doing at this time. Looks good to me otherwise!

Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some additional suggestions for review. We can discuss these in our call in a few minutes.

_data/accessibility-tests/file-input.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/file-input.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks team for all the discussion on this!

Copy link
Contributor

@finekatie finekatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS-Site: Publish file input accessibility checklist page
5 participants