USWDS-Site: Replaced deprecated xlink:href code with recommended use of href #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RachelCorsino
requested review from
amyleadem,
mejiaj,
mahoneycm and
cathybaptista
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mahoneycm
requested changes
Oct 31, 2024
There was a problem hiding this comment.
issue: This image is failing to find and saying it's an invalid source. Can you look into this? It's appearing on develop
mejiaj
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
All
xlink:hrefinstances have be replaced withhrefwithin the repo in order to account for the deprecation ofxlink:href.Related issue
Closes USWDS - Bug: xlink:href deprecated #6088 from USWDS repo. This issue extends to fixes needed in USWDS-Site.
Preview link
Preview link:
USWDS Icon Component Page
Problem statement
The USWDS-Site repository currently contains numerous instances of xlink:href, which is a deprecated attribute that may cause compatibility issues/errors.
Solution
The USWDS-Site repository has been updated to use the
hrefattribute instead of the deprecatedxlink:hrefattribute.Testing and review
xlink:href.