Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roman variable font: instance coordinates for Thin and ExtraLight are not multiples of 100 #119

Closed
eliheuer opened this issue Oct 22, 2019 · 3 comments

Comments

@eliheuer
Copy link

On the specimen page instance weights are listed as multiples of 100: https://public-sans.digital.gov/

However, in the glyphs source file ExtraLight is set to 275 and Thin is set to 250.
Please see: Font Info > Instances > Custom Parameters > weightClass

This also causes a FontBakery fail, which needs to pass in order to close issue #29:

Fontbakery report

Fontbakery version: 0.7.14

[1] PublicSans[wght].ttf
🔥 FAIL: Check variable font instances have correct coordinate values

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 1 0 0 0 0 0
0% 100% 0% 0% 0% 0% 0%

Please see the discussion in this pull request for further info: google/fonts#2009 (comment)

I'm going to change these values in my fork I'm making the above pull request from, but unless I'm missing something this seems worth change in the upstream source files.

eliheuer added a commit to eliheuer/public-sans that referenced this issue Oct 23, 2019
eliheuer added a commit to eliheuer/public-sans that referenced this issue Oct 23, 2019
@thisisdano
Copy link
Member

@eliheuer When I run FontBakery it gives me an error and asks that I change the Thin and ExtraLight values to 250 and 275, respectively.

https://github.com/googlefonts/fontbakery/blob/5bcaa446d6b1ccabe1e8c48d7076280f15c4cc89/Lib/fontbakery/profiles/googlefonts_conditions.py#L50

Does that error make sense to you? Is it correct? Am I running FontBakery properly?
Is there a way to address both that error and this issue?

@davelab6
Copy link

davelab6 commented Nov 6, 2019

I believe this is a bug in Font Bakery; the weight axis should have named instances for Thin and ExtraLight at 100 and 200.

The "no OS/2 usWeightClass value below 250" dogma was to prevent OpenType CFF (.otf) fonts from being auto-bolded by the Windows OS, and it sort of made sense to have the CFF and TTF flavors as similar as possible, but in 2019 when TTF flavor VFs are currently more widely supported than CFF2 flavor VFs, that FB check doesn't make sense.

@felipesanches

@thisisdano
Copy link
Member

Addressed in #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants