-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roman variable font: instance coordinates for Thin and ExtraLight are not multiples of 100 #119
Comments
@eliheuer When I run FontBakery it gives me an error and asks that I change the Thin and ExtraLight values to 250 and 275, respectively. Does that error make sense to you? Is it correct? Am I running FontBakery properly? |
I believe this is a bug in Font Bakery; the weight axis should have named instances for Thin and ExtraLight at 100 and 200. The "no OS/2 usWeightClass value below 250" dogma was to prevent OpenType CFF ( |
Addressed in #123 |
On the specimen page instance weights are listed as multiples of 100: https://public-sans.digital.gov/
However, in the glyphs source file ExtraLight is set to 275 and Thin is set to 250.
Please see: Font Info > Instances > Custom Parameters > weightClass
This also causes a FontBakery fail, which needs to pass in order to close issue #29:
Fontbakery report
Fontbakery version: 0.7.14
[1] PublicSans[wght].ttf
🔥 FAIL: Check variable font instances have correct coordinate values
Summary
Please see the discussion in this pull request for further info: google/fonts#2009 (comment)
I'm going to change these values in my fork I'm making the above pull request from, but unless I'm missing something this seems worth change in the upstream source files.
The text was updated successfully, but these errors were encountered: