Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported to VS 2015 #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Ported to VS 2015 #3

wants to merge 4 commits into from

Conversation

maxbruecken
Copy link

Hi,

I have ported Usus.NET to VS 2015 and replaced some libs with NuGet packages.

Best regards,

Maxim

@halllo
Copy link
Member

halllo commented Dec 20, 2016

Hi Maxim.

Thanks, that is very cool! I reviewed it and found two things I would like you to have a look at before I merge it.

  1. Usus.net.Core still references GraphSharp in lib which should also be the nuget package. And there is another invalid reference, I think in Usus.net.Shell.
  2. A few of the integration tests fail. For example verification of CyclomaticComplexity. I suspect that is because the compiler generates different IL now. Please have a look at those tests and see if they fail for a valid reason or not.

Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants