Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify upload expectations for BM 1 to 4 #1511

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

tkphd
Copy link
Collaborator

@tkphd tkphd commented Aug 10, 2023

This PR adapts the clarified BM1 upload instructions for BM2 to BM4. The remaining specifications have reasonably clear instructions already.

@tkphd tkphd requested review from guyer and wd15 August 10, 2023 21:20
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@pfhub
Copy link

pfhub commented Aug 10, 2023

@tkphd, the new version of the PFHub website is available at https://random-cat-1511.surge.sh

@tkphd
Copy link
Collaborator Author

tkphd commented Aug 10, 2023

... some of the Jekyll templating didn't go through on my local make, @wd15 please work your magic 😄

Rerun notebook build to fix Jekyll templating issues from tkphd. Don't
know why mine works and tkphd's doesn't..
@pfhub
Copy link

pfhub commented Aug 13, 2023

@tkphd, the new version of the PFHub website is available at https://random-cat-1511.surge.sh

@wd15
Copy link
Collaborator

wd15 commented Aug 13, 2023

This all looks great. Just one thing, could you remove notebooks 1 and 4 from this PR as they don't have any real changes (just white space and python versions)? Thanks.

Copy link
Collaborator

@wd15 wd15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove BM1 and BM4 notebooks from PR

@tkphd
Copy link
Collaborator Author

tkphd commented Aug 14, 2023

Dropped BM1 and BM4+; probably need to regenerate everything again.

@pfhub
Copy link

pfhub commented Aug 14, 2023

@tkphd, the new version of the PFHub website is available at https://random-cat-1511.surge.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants