Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(staticman): use wd15-staticman.herokuapp.com #1025

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

wd15
Copy link
Collaborator

@wd15 wd15 commented Aug 26, 2019

Address #899

Use wd15-staticman.herokuapp.com instead of https://dev.staticman.net
for new PFHub Staticman instance hosted on Heroku.

Running up against "Application Error' when using https://dev.staticman.net, which is the public instance of Staticman. Decided to roll out a PFHub dedicated Staticman hosted on the free tier of Heroku. Hopefully, this will be more stable going forward. Also, will give us more flexibility to adjust the way Staticman works and more easily interact with out Python backend app.

Currently using this version of staticman.

These changes can be viewed live.

Remember to tear down the live site when merging
or closing this pull request.


This change is Reviewable

Use wd15-staticman.herokuapp.com instead of https://dev.staticman.net
to test new PFHub Staticman instance hosted on Heroku.
@wd15 wd15 changed the title [WIP] build(staticman): use wd15-staticman.herokuapp.com build(staticman): use wd15-staticman.herokuapp.com Aug 26, 2019
@wd15 wd15 requested a review from tkphd August 26, 2019 19:53
@wd15 wd15 added this to the November 2019 Meeting milestone Aug 26, 2019
@tkphd
Copy link
Collaborator

tkphd commented Aug 26, 2019

"More stable" in that we expect Heroku to have better uptime than Staticman?

@tkphd
Copy link
Collaborator

tkphd commented Aug 26, 2019

@wd15, please comment on the impact of this change on maintainability of PFHub.

@wd15
Copy link
Collaborator Author

wd15 commented Aug 26, 2019

Few reasons for this change (nothing to do with uptime or Heroku as the public instance is also hosted from Heroku):

  • the public instance keeps changing and breaking due to changes that aren't documented or due to GitHub API limits
  • the main contributor is no longer responding much on GitHub (31 oepn pull requests) so changes aren't documented other than in issue comments which are hard to track
  • there are other public instances, but it's very easy to deploy and safer to have our own instance
  • it's very easy to change between different instances if necessary so it isn't much of issue switching between instances
  • the endpoint will just stay the same unless I actually want to change make a change
  • we can start adding features like GitHub authentication into our own version (which we can choose to push back if the main developed becomes active again)

Some relevant comments:

@wd15
Copy link
Collaborator Author

wd15 commented Aug 27, 2019

@wd15, please comment on the impact of this change on maintainability of PFHub.

It'll make it easier to maintain if anything as we won't have to deal with Staticman end points changing and having no control over the app.

Copy link
Collaborator

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkphd tkphd assigned wd15 and unassigned tkphd Aug 27, 2019
@wd15 wd15 merged commit f19b387 into usnistgov:master Aug 28, 2019
@wd15 wd15 deleted the issue899-staticman branch August 28, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants