Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Hugo USWDS theme as a Hugo module #422

Merged
merged 16 commits into from
Sep 27, 2023
Merged

Use Hugo USWDS theme as a Hugo module #422

merged 16 commits into from
Sep 27, 2023

Conversation

david-waltermire
Copy link
Collaborator

@david-waltermire david-waltermire commented Sep 1, 2023 •
edited
Loading

Committer Notes

This PR updates the Hugo configuration and supporting files to use the USWDS theme as a Hugo module.

This work was moved out of PR #393.

Some general cleanup of the repository is also included.

Resolves #349.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@david-waltermire david-waltermire changed the base branch from main to develop September 1, 2023 13:01
@david-waltermire david-waltermire force-pushed the issue349-hugo-modules branch 2 times, most recently from 4dbf656 to b7ead70 Compare September 1, 2023 13:12
@david-waltermire david-waltermire mentioned this pull request Sep 1, 2023
Merged
9 tasks
@david-waltermire david-waltermire force-pushed the issue349-hugo-modules branch 4 times, most recently from 04327f8 to f7e4648 Compare September 7, 2023 14:07
@david-waltermire david-waltermire force-pushed the issue349-hugo-modules branch 2 times, most recently from 252d292 to f0b0170 Compare September 27, 2023 18:35
@david-waltermire
cleanup build paths
e1d9544
@david-waltermire
Convert Hugo USWDS theme to use a module. Resolves usnistgov#349.
e10f192
@david-waltermire
Refactored Hugo configuration to use config subdirectory.
1916d58 
Separated website JSON dependencies from other site dependencies, i.e. build vs website/config/_default/hugo.yaml
Setup postcss config for CSS processing.
Updated to latest hugo-uswds as a Hugo module.
@david-waltermire
Fixed broken workflow.
65133ab
@david-waltermire
Relocated package-lock.json
b19246d
@david-waltermire
Removed deprecated language config.
48526a1
@david-waltermire
Switched to vendoring hugo modules.
74277a8 
NPM configuration cleanup.
@david-waltermire
Acquiring Hugo now through GHA to reduce build time.
0ff7a74
@david-waltermire
Removed go setup
f380c16
@david-waltermire
Cleaned up the theme configuration and updated Hugo module config to …
05d8d07 
…use the latest development version of hugo-uswds-nist.

Also cleaned up the CONTRIBUTING.md to remove sprint language.
@david-waltermire
Updating workflows to latest used in similar repos.
e43fb72
@david-waltermire
Added USERS.md explaining who the project applies to.
4c34477
@david-waltermire
Fixed unregognized entry in Golang module.
b2c8d47
@david-waltermire
Fixing broken link in generated documentation.
8f62900
@david-waltermire
Added website 404 page.
466db49
@david-waltermire david-waltermire marked this pull request as ready for review September 27, 2023 19:16
aj-stein-nist
aj-stein-nist previously approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I only have minor, non-blocking commentary.

.github/workflows/link-check.yml Show resolved Hide resolved
.github/workflows/config/.markdown-link-check/config.json Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
USERS.md Show resolved Hide resolved
@david-waltermire david-waltermire merged commit ed191c5 into usnistgov:develop Sep 27, 2023
3 checks passed
@david-waltermire david-waltermire deleted the issue349-hugo-modules branch September 27, 2023 21:41
@aj-stein-nist aj-stein-nist mentioned this pull request Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj-stein-nist aj-stein-nist aj-stein-nist left review comments

@nikitawootten-nist nikitawootten-nist Awaiting requested review from nikitawootten-nist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transition USWDS Hugo theme to use Hugo Modules
2 participants
@david-waltermire @aj-stein-nist