-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't Mark Recursive Assemblies Empty in Doc Generation #234
Merged
david-waltermire
merged 1 commit into
usnistgov:develop
from
aj-stein-nist:225-metaschema-doc-generator-marks-certain-assemblies-empty-when-they-arent
Sep 19, 2022
Merged
Don't Mark Recursive Assemblies Empty in Doc Generation #234
david-waltermire
merged 1 commit into
usnistgov:develop
from
aj-stein-nist:225-metaschema-doc-generator-marks-certain-assemblies-empty-when-they-arent
Sep 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Sep 6, 2022
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Sep 6, 2022
See more details about analysis and PR changes below: usnistgov#225 (comment) usnistgov#225 (comment) Co-authored-by: Wendell Piez <[email protected]>
aj-stein-nist
force-pushed
the
225-metaschema-doc-generator-marks-certain-assemblies-empty-when-they-arent
branch
from
September 6, 2022 22:23
18c946c
to
bd0fbb0
Compare
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Sep 6, 2022
david-waltermire
approved these changes
Sep 9, 2022
david-waltermire
approved these changes
Sep 19, 2022
6 tasks
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Oct 6, 2022
david-waltermire
pushed a commit
that referenced
this pull request
Dec 7, 2022
See more details about analysis and PR changes below: #225 (comment) Co-authored-by: Wendell Piez <[email protected]>
aj-stein-nist
added a commit
to aj-stein-nist/metaschema
that referenced
this pull request
Jan 9, 2023
See more details about analysis and PR changes below: usnistgov#225 (comment) Co-authored-by: Wendell Piez <[email protected]>
aj-stein-nist
added a commit
to aj-stein-nist/metaschema
that referenced
this pull request
Jan 10, 2023
See more details about analysis and PR changes below: usnistgov#225 (comment) Co-authored-by: Wendell Piez <[email protected]>
aj-stein-nist
added a commit
to aj-stein-nist/metaschema
that referenced
this pull request
Jan 10, 2023
See more details about analysis and PR changes below: usnistgov#225 (comment) Co-authored-by: Wendell Piez <[email protected]>
aj-stein-nist
added a commit
to aj-stein-nist/metaschema
that referenced
this pull request
Jan 10, 2023
See more details about analysis and PR changes below: usnistgov#225 (comment) Co-authored-by: Wendell Piez <[email protected]>
aj-stein-nist
added a commit
to aj-stein-nist/metaschema
that referenced
this pull request
Jan 10, 2023
See more details about analysis and PR changes below: usnistgov#225 (comment) Co-authored-by: Wendell Piez <[email protected]>
aj-stein-nist
added a commit
to aj-stein-nist/metaschema
that referenced
this pull request
Jan 10, 2023
See more details about analysis and PR changes below: usnistgov#225 (comment) Co-authored-by: Wendell Piez <[email protected]>
david-waltermire
pushed a commit
that referenced
this pull request
Mar 9, 2023
See more details about analysis and PR changes below: #225 (comment) Co-authored-by: Wendell Piez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Closes #225.
Example screenshots of updated website reflecting this change are below.
On my fork of OSCAL with sub-module updates and PR branch overwritten with a push to fork's
main
branch for this review, CI/CD workflows run, and potentially updated website generated for quick review, see below.main
model commit updates: aj-stein-nist/OSCAL@51bb896#diff-f039f72d385c834bf21ba4e0a00619389b632bac1f9b309362fbd31365e9a296L831-R833nist-pages
resulting run with models[Empty]
cleaned up: aj-stein-nist/OSCAL@bbf8a53#diff-47a5874d1941f36a7db87af65d074c457e8c1c65483f0a45ca855b42d36df69fAll Submissions:
Changes to Core Features:
Have you included examples of how to use your new feature(s)?