Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate support for @collapsible #354

Closed
Tracked by #418
david-waltermire opened this issue Apr 14, 2023 · 1 comment · Fixed by #405 or #418
Closed
Tracked by #418

Deprecate support for @collapsible #354

david-waltermire opened this issue Apr 14, 2023 · 1 comment · Fixed by #405 or #418
Labels
specification Improvements or additions to the specification

Comments

@david-waltermire
Copy link
Collaborator

david-waltermire commented Apr 14, 2023

Discussed on the 4/7/2023 community call deprecating and possibly removing support for @collapsible on fields.

See comment posted by @aj-stein-nist in #329 (comment).

@david-waltermire david-waltermire added this to the Metaschema 1.0.0 milestone Jun 8, 2023
@david-waltermire david-waltermire added the specification Improvements or additions to the specification label Jun 8, 2023
@david-waltermire david-waltermire linked a pull request Aug 2, 2023 that will close this issue
8 tasks
david-waltermire added a commit to david-waltermire/metaschema-java-old that referenced this issue Aug 2, 2023
…chemaJsonParser class. This resulted in a cleaner set of bound definition/property classes that no contain no parsing code.

Removed collapsible per usnistgov/metaschema#354.
Renamed XmlParser to MetaschemaXmlParser.
david-waltermire added a commit to david-waltermire/metaschema-java-old that referenced this issue Aug 14, 2023
…chemaJsonParser class. This resulted in a cleaner set of bound definition/property classes that no contain no parsing code.

Removed collapsible per usnistgov/metaschema#354.
Renamed XmlParser to MetaschemaXmlParser.
david-waltermire added a commit to david-waltermire/metaschema-java-old that referenced this issue Aug 15, 2023
…chemaJsonParser class. This resulted in a cleaner set of bound definition/property classes that no contain no parsing code.

Removed collapsible per usnistgov/metaschema#354.
Renamed XmlParser to MetaschemaXmlParser.
david-waltermire added a commit to david-waltermire/metaschema-java-old that referenced this issue Aug 28, 2023
…chemaJsonParser class. This resulted in a cleaner set of bound definition/property classes that no contain no parsing code.

Removed collapsible per usnistgov/metaschema#354.
Renamed XmlParser to MetaschemaXmlParser.
@david-waltermire david-waltermire linked a pull request Aug 30, 2023 that will close this issue
9 tasks
david-waltermire added a commit to david-waltermire/metaschema-java-old that referenced this issue Sep 20, 2023
…chemaJsonParser class. This resulted in a cleaner set of bound definition/property classes that no contain no parsing code.

Removed collapsible per usnistgov/metaschema#354.
Renamed XmlParser to MetaschemaXmlParser.
david-waltermire added a commit to david-waltermire/metaschema-java-old that referenced this issue Sep 21, 2023
…chemaJsonParser class. This resulted in a cleaner set of bound definition/property classes that no contain no parsing code.

Removed collapsible per usnistgov/metaschema#354.
Renamed XmlParser to MetaschemaXmlParser.
david-waltermire added a commit to david-waltermire/metaschema-java-old that referenced this issue Sep 26, 2023
…chemaJsonParser class. This resulted in a cleaner set of bound definition/property classes that no contain no parsing code.

Removed collapsible per usnistgov/metaschema#354.
Renamed XmlParser to MetaschemaXmlParser.
david-waltermire added a commit to usnistgov/metaschema-java that referenced this issue Sep 26, 2023
* Migrated modules:
  - Relocated metaschema-model-common to metaschema-core in folder core.
  - Relocated metaschema-model to metaschema-core in folder core.
    - Moved metaschema submodule to core.
  - Relocated the "metaschema-java-binding" and "metaschema-java-codegen" modules to the databind module.
  - Moved metaschema-schema-generator to schemagen.
* Cleaned up reports.
* Ensured generated resources are included for site generation.
* Cleaned up some unneeded generics in the implementation.
* Added many Javadoc comments.
* Relocated unit tests to match new package structure.
* Added a new mock model builder (MockedModelTestSupport) to facilitate creation of unit tests around using a mocked Metaschema model.
* Setup JPMS module-info for the core module.
* Some Maven dependency cleanup, including removing unused dependencies.
  - Removed dependency on JAXB.
* Removed aggregate javadoc.
* Eliminated a significant number of compile, PMD, CPD duplications, and Spotbugs warnings.
* Cleaned up some unused/unneeded classes and methods.
* Improved some logging messages.
* Use treeless Git clones on GHA builds
* Updating to latest oss-maven release.
* Core changes:
  - Added `true()` and `false()` metapath function.
  - Refactored error handling for step-related Metapath expressions to ensure the provided context node item is non-null and a document. This also lays ground work for null node contexts in Metapath expressions that do not require a focused node.
  - Refactored code to remove the IRequiredValue* interfaces.
  - Migrated node item classes to a new package.
  - Refactored INodeItem handling to implement the following correct behaviors:
    - IDocumentNodeItem instances will never have a value (i.e. getValue == null)
    - Root metapaths (i.e. `/`) must be executed against an IDocumentNodeItem or an error should be raised.
  - Refactored node item implementation to provide better interface segregation and to limit class responsibility.
  - Refactored Metapath focus to allow for Metapath evaluations against no focus, as well as cases where the focus is not a node item.
  - Improved memory footprint for Axis expressions, which now use static objects for evaluation. Refactored the Step and ParentItem ASTs to use the new Axis support.
  - Added support for function namespaces.
  - Removed collapsible per usnistgov/metaschema#354.
  - Moved property info factory to static method on IModelPropertyInfo.
  - Adjusted IDataTypeHandler creation to avoid extra method callbacks.
  - Reduced unnecessary overridden methods.
  - Removed the need for specific root assembly model interfaces and classes.
  - Renamed IMetaschema to IModule to be more consistent with terminology.
Deleted unused submodule.
  - For index constraints, enhanced index key miss error reporting to include the key data that missed.
  - Added new String initializer for IAnyAtomicItem.
* Databind changes:
  - Refactored JSON reader and writer to use common instance logic. The collection of instances are now lazy generated and cached, improving read and write performance for commonly accessed Metaschema-based JSON objects.
  - Refactored XML parsing, extracting XML parsing logic into the XmlParser class. This resulted in a cleaner set of bound definition/property classes. Also optimized deserialization to return the Object value directly, instead of first creating an unneeded node item.
  - Refactored JSON parsing, extracting JSON parsing logic into the MetaschemaJsonParser class. This resulted in a cleaner set of bound definition/property classes that no contain no parsing code.
  - Renamed XmlParser to MetaschemaXmlReader, MetaschemaJsonParser to MetaschemaJsonReader, and MetaschemaXmlGenerator to MetaschemaXmlWriter.
  - Cleaned up some collapse unit testing files.
  - Implemented XML problem handler for parsing. Further code cleanup and refactoring of XML parsing code.
  - Implemented the JSON problem handler. Resolved #131.
  - Refactored JSON parser tests.
  - Refactored input stream handling. Input streams should now be properly closed.
  - Adjusted problem handlers to use interface defaults and a common implementation of default handling for missing instances.
  - Refactored binding context to allow for dynamic class generation, compilation, and loading. Removed DynamicBindingContext.java, which is no longer needed.
  - Adjusted YAML parser configuration to set a higher default codepoint limit.
  - Refactored code generation, moving code generation methods into a dedicated class.
  - Refactored code generation production classes to simplify and reduce the number of classes.
* Schema generation changes:
  - Refactored XML and JSON generation by moving generation code into format specific classes (i.e. MetaschemaJsonWriter, MetaschemaXmlWriter).
  - Improved XML schema generation testing.
* Metaschema Maven plugin changes:
  - Adjusted generate sources mojo default phase to a more reasonable value (generate-sources).
@david-waltermire
Copy link
Collaborator Author

These changes have been staged for the v1.0.0 release.

david-waltermire added a commit that referenced this issue Oct 4, 2023
* Removed support for collapsible. Resolves #354 (#405)
* Adjusting data types in test for greater diversity.
david-waltermire added a commit that referenced this issue Oct 19, 2023
* Removed support for collapsible. Resolves #354 (#405)
* Adjusting data types in test for greater diversity.
david-waltermire added a commit that referenced this issue Nov 10, 2023
* Added prop to the top-level metadata. Also fixed a few small editorial issues in documentation.
* Feature integer indexes (#442)

* Refactoring index naming to use more concise and consistent attribute names.

* Reducing verbosity of index names.

* Staging changes for v1.0.0 (#418)

* Removed support for collapsible. Resolves #354 (#405)
* Adjusting data types in test for greater diversity.

* Updated default extension value

* Fix Metaschema XSD binding to fix #462. (#463)

* Bump sass from 1.66.1 to 1.69.4 (#467)

Bumps [sass](https://github.com/sass/dart-sass) from 1.66.1 to 1.69.4.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](sass/dart-sass@1.66.1...1.69.4)

---
updated-dependencies:
- dependency-name: sass
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/checkout from 4.1.0 to 4.1.1 (#468)

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@8ade135...b4ffde6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump postcss from 8.4.29 to 8.4.31 (#435)

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.29 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.29...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump autoprefixer from 10.4.15 to 10.4.16 (#432)

Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 10.4.15 to 10.4.16.
- [Release notes](https://github.com/postcss/autoprefixer/releases)
- [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md)
- [Commits](postcss/autoprefixer@10.4.15...10.4.16)

---
updated-dependencies:
- dependency-name: autoprefixer
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Apply suggestions from code review

Addressing terminology based on feedback from @wendellpiez.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: A.J. Stein <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
david-waltermire added a commit that referenced this issue Jan 4, 2024
* Removed support for collapsible. Resolves #354 (#405)
* Adjusting data types in test for greater diversity.
david-waltermire added a commit that referenced this issue Jan 4, 2024
* Added prop to the top-level metadata. Also fixed a few small editorial issues in documentation.
* Feature integer indexes (#442)

* Refactoring index naming to use more concise and consistent attribute names.

* Reducing verbosity of index names.

* Staging changes for v1.0.0 (#418)

* Removed support for collapsible. Resolves #354 (#405)
* Adjusting data types in test for greater diversity.

* Updated default extension value

* Fix Metaschema XSD binding to fix #462. (#463)

* Bump sass from 1.66.1 to 1.69.4 (#467)

Bumps [sass](https://github.com/sass/dart-sass) from 1.66.1 to 1.69.4.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](sass/dart-sass@1.66.1...1.69.4)

---
updated-dependencies:
- dependency-name: sass
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/checkout from 4.1.0 to 4.1.1 (#468)

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@8ade135...b4ffde6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump postcss from 8.4.29 to 8.4.31 (#435)

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.29 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.29...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump autoprefixer from 10.4.15 to 10.4.16 (#432)

Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 10.4.15 to 10.4.16.
- [Release notes](https://github.com/postcss/autoprefixer/releases)
- [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md)
- [Commits](postcss/autoprefixer@10.4.15...10.4.16)

---
updated-dependencies:
- dependency-name: autoprefixer
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Apply suggestions from code review

Addressing terminology based on feedback from @wendellpiez.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: A.J. Stein <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
specification Improvements or additions to the specification
Projects
None yet
1 participant