Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XSD datatype glitch in XSLT M4 schema generator #223

Closed
wendellpiez opened this issue Aug 15, 2022 · 5 comments · Fixed by #227
Closed

XSD datatype glitch in XSLT M4 schema generator #223

wendellpiez opened this issue Aug 15, 2022 · 5 comments · Fixed by #227
Assignees
@wendellpiez
Labels
bug Something isn't working

Comments

@wendellpiez
Copy link
Collaborator

Describe the bug

For whatever reason, derived datatypes are not capturing their base types in the generated XSDs (XSLT M4 implementation, develop branch). For example, dateTime-with-timezone should be defined as a restriction on dateTime, but is coming through as a restriction on string.

Who is the bug affecting?

Downstream users of the XSD who do not have correct data type bindings.

What is affected by this bug?

Difficult to determine, but this has potential impacts on XSD-based applications.

When does this occur?

Reliably on certain datatypes in OSCAL (that are derived by restriction).

How do we replicate the issue?

Examine any generated schema.

Expected behavior (i.e. solution)

Schemas should reflect the derivation of the type, not erase it.
@wendellpiez wendellpiez added the bug Something isn't working label Aug 15, 2022
@wendellpiez
Copy link
Collaborator Author

wendellpiez commented Aug 18, 2022 •
edited
Loading

Current plan:

Then we have a start at #224 (exposing the regex issues).

wendellpiez added a commit to wendellpiez/metaschema that referenced this issue Aug 19, 2022
@wendellpiez
Addressing Issue usnistgov#223: now includes all simpleType definitio…
4316dae 
…ns down their dependency graph (within a given set of definitions), preventing orphans when atomic datatypes are built on top of one another in XSD generation.
@wendellpiez
Copy link
Collaborator Author

wendellpiez commented Aug 19, 2022 •
edited
Loading

PR #227 addresses this Issue.

Plus we will revisit unit testing with #224.

@wendellpiez wendellpiez moved this from Todo to Under Review in NIST OSCAL Work Board Aug 19, 2022
@wendellpiez
Copy link
Collaborator Author

Actually - the bug found and repaired for #227 may not be this one, at least as described in this Issue (which was transcribed from a note). TBD.

david-waltermire pushed a commit to wendellpiez/metaschema that referenced this issue Aug 21, 2022
@wendellpiez @david-waltermire
Addressing Issue usnistgov#223: now includes all simpleType definitio…
59e6543 
…ns down their dependency graph (within a given set of definitions), preventing orphans when atomic datatypes are built on top of one another in XSD generation.
@david-waltermire david-waltermire moved this from Under Review to In Progress in NIST OSCAL Work Board Aug 21, 2022
@david-waltermire david-waltermire linked a pull request Aug 21, 2022 that will close this issue
repairing XSD simple type definition defect #227
Merged
8 tasks
@david-waltermire
Copy link
Collaborator

@wendellpiez The specific error can be verified by validating the OSCAL catalog XML schema.

@wendellpiez
Copy link
Collaborator Author

The schema generated from adjusted XSD comes up without errors, and the diff shows new structures (only).

Thanks @david-waltermire-nist for the reference point.

@wendellpiez wendellpiez moved this from In Progress to Under Review in NIST OSCAL Work Board Aug 22, 2022
david-waltermire pushed a commit that referenced this issue Aug 23, 2022
@wendellpiez
Addressing Issue #223: now includes all simpleType definitions down t…
1e08f4b 
…heir dependency graph (within a given set of definitions), preventing orphans when atomic datatypes are built on top of one another in XSD generation. (#227)
Repository owner moved this from Under Review to Done in NIST OSCAL Work Board Aug 23, 2022
david-waltermire pushed a commit that referenced this issue Dec 7, 2022
@wendellpiez @david-waltermire
Addressing Issue #223: now includes all simpleType definitions down t…
2518267 
…heir dependency graph (within a given set of definitions), preventing orphans when atomic datatypes are built on top of one another in XSD generation. (#227)
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this issue Jan 9, 2023
@wendellpiez @aj-stein-nist
Addressing Issue usnistgov#223: now includes all simpleType definitio…
2797b99 
…ns down their dependency graph (within a given set of definitions), preventing orphans when atomic datatypes are built on top of one another in XSD generation. (usnistgov#227)
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this issue Jan 10, 2023
@wendellpiez @aj-stein-nist
Addressing Issue usnistgov#223: now includes all simpleType definitio…
643a828 
…ns down their dependency graph (within a given set of definitions), preventing orphans when atomic datatypes are built on top of one another in XSD generation. (usnistgov#227)
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this issue Jan 10, 2023
@wendellpiez @aj-stein-nist
Addressing Issue usnistgov#223: now includes all simpleType definitio…
07bedca 
…ns down their dependency graph (within a given set of definitions), preventing orphans when atomic datatypes are built on top of one another in XSD generation. (usnistgov#227)
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this issue Jan 10, 2023
@wendellpiez @aj-stein-nist
Addressing Issue usnistgov#223: now includes all simpleType definitio…
d6b492c 
…ns down their dependency graph (within a given set of definitions), preventing orphans when atomic datatypes are built on top of one another in XSD generation. (usnistgov#227)
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this issue Jan 10, 2023
@wendellpiez @aj-stein-nist
Addressing Issue usnistgov#223: now includes all simpleType definitio…
de2759c 
…ns down their dependency graph (within a given set of definitions), preventing orphans when atomic datatypes are built on top of one another in XSD generation. (usnistgov#227)
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this issue Jan 10, 2023
@wendellpiez @aj-stein-nist
Addressing Issue usnistgov#223: now includes all simpleType definitio…
2e0fd96 
…ns down their dependency graph (within a given set of definitions), preventing orphans when atomic datatypes are built on top of one another in XSD generation. (usnistgov#227)
david-waltermire pushed a commit that referenced this issue Mar 9, 2023
@wendellpiez @david-waltermire
Addressing Issue #223: now includes all simpleType definitions down t…
6086706 
…heir dependency graph (within a given set of definitions), preventing orphans when atomic datatypes are built on top of one another in XSD generation. (#227)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wendellpiez wendellpiez

Labels
bug Something isn't working
Projects
NIST OSCAL Work Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

repairing XSD simple type definition defect wendellpiez/metaschema
2 participants
@wendellpiez @david-waltermire