Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON examples for FedRAMP profiles #233

Closed
wants to merge 1 commit into from

Conversation

anweiss
Copy link
Contributor

@anweiss anweiss commented Aug 30, 2018

Committer Notes

Adds the following JSON examples for the FedRAMP profiles to address #197:

FedRAMP_HIGH-baseline_profile.json
FedRAMP_MODERATE-baseline_profile.json
FedRAMP_LOW-baseline_profile.json

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]

@iMichaela
Copy link
Contributor

iMichaela commented Sep 5, 2018

9/4/2018 PR Review

We need to decide if we want the uuid to be identical for the JSON version and for the XML version of the catalog or profile. Also the publication date it is currently identical on both versions of the file. While uuid could be the same, I think the publication date might need to remain true to the real publication date. We also discussed under #220 to look into using the NIST Beacon to obtain a unique file identifier.

Also, the examples still contain the XML paragraph markup (

). Is it possible to remove the 500+ instances from these versions of the files or do we have other dependencies or challenges (e.g. no round-trip support yet)?

@david-waltermire
Copy link
Contributor

david-waltermire commented Sep 25, 2018

@iMichaela I believe the UUIDs for the XML and JSON versions should be different, since these are different instances. We need to address this question in the context of issues #196 and #221.

In my view we need to identify the following three things:

  1. The document instance identifier, which is unique for each document.
  2. The dataset identifier, which is the same for each serialization of a given catalog, profile, or implementation data revision (e.g., SP 800-53 rev4 updated on X date).
  3. A subject identifier that is the same for all revisions of the same catalog, profile, or implementation. This can be used to track revisions of a given publication (e.g., SP 800-53 rev4)

The instances in this PR use the same UUID for the id. which provides #2 above. I believe it should be #1 above, but we need to talk about this.

@iMichaela I don't understand your comment about " Is it possible to remove the 500+ instances from these versions of the files". Can you clarify?

@iMichaela
Copy link
Contributor

@david-waltermire-nist I concur with the file uuid structure you described:

  1. The document instance identifier, which is unique for each document.
  2. The dataset identifier, which is the same for each serialization of a given catalog, profile, or implementation data revision (e.g., SP 800-53 rev4 updated on X date).
  3. A subject identifier that is the same for all revisions of the same catalog, profile, or implementation. This can be used to track revisions of a given publication (e.g., SP 800-53 rev4)
    I suggest though we should consider having a way of identifying coupling the XML and JSON pairs of the same information.

@david-waltermire-nist : I am referring to the 500+ instances of \u003cp\u003e that come from the paragraph tag

in XML

@iMichaela
Copy link
Contributor

9/27/2018

#197 has been reassigned to @wendellpiez who will create a new PR using the metaschema toolchain.

@iMichaela iMichaela closed this Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants