Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update automation to centralized triage board #1936

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Sep 27, 2023

Committer Notes

The old board (https://github.com/usnistgov/OSCAL/projects/52) has been deprecated and it is time to switch board automation. Repo admins will get emails on every triage automation failure as old board is closed. There is no attached issue as this work is helpful to ensure there is a limited gap in triage board coverage as we finish the initial migration from the old per-project boards.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable? N/A
  • Have you included examples of how to use your new feature(s)? N/A
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch. N/A

The old board (https://github.com/usnistgov/OSCAL/projects/52) has been deprecated and it is time to switch board automation. Repo admins will get emails on every triage automation failure as old board is closed.
@aj-stein-nist aj-stein-nist self-assigned this Sep 27, 2023
@aj-stein-nist aj-stein-nist added Scope: CI/CD Enhancements to the project's Continuous Integration and Continuous Delivery pipeline. Developer Experience Issues around enhancing and optimizing work for development of NIST OSCAL artifacts labels Sep 27, 2023
@aj-stein-nist
Copy link
Contributor Author

May need to set up a test board tomorrow afternoon on my fork to confirm it is working before converting from draft to ready PR for team review.

aj-stein-nist added a commit to ImportantFederalAgencyTest/test-project-integration-repo that referenced this pull request Sep 27, 2023
Testing this works after merge with oscalbuilder PAT and similar permissions.
aj-stein-nist added a commit to ImportantFederalAgencyTest/test-project-integration-repo that referenced this pull request Sep 27, 2023
Can't use cross-org projects like that, doesn't make sense for testing. 🤦
I found this other issue type when reading GitHub's documentation and reviewing it for debugging steps.
@aj-stein-nist aj-stein-nist marked this pull request as ready for review September 27, 2023 22:55
@aj-stein-nist
Copy link
Contributor Author

As linked with a test repository, it appears very important to the one official action set up for this purpose, made by GitHub themselves, and the underlying GraphQL API that it is a strong requirement the account (in this case, oscalbuilder service account be a member of the usnistgov org. For the projects workflow, automatic addition by filter can only work with one repo given the usnistgov org payment plan, so getting GitHub Actions to work is necessary and will vastly reduce tool regarding automated management of the board. Will talk to the NIST team that manages GitHub tomorrow morning or before end of this week if we can determine how to do that, and if so moved forward.

For the time, being, I will mark this as blocked. I thought this would be quick, but foiled once again by permissions. 😢

@aj-stein-nist aj-stein-nist changed the title Update automation to centralized triage board [DONOTMERGE] Update automation to centralized triage board Sep 27, 2023
@aj-stein-nist aj-stein-nist changed the title [DONOTMERGE] Update automation to centralized triage board Update automation to centralized triage board Sep 28, 2023
@aj-stein-nist
Copy link
Contributor Author

This is no longer blocked and ready for review. Thanks to @agmorey and the team that manages the usnistgov org for the assist!

@aj-stein-nist aj-stein-nist requested a review from a team September 28, 2023 13:30
@aj-stein-nist
Copy link
Contributor Author

Also of note that the action, made by GitHub developers, must use a PAT (classic token, not beta fine-grained at the time of this writing) and new tokens must have public_repo and full project scopes (not read:project only) for this to work based on yesterday's testing. Screenshot of updated PAT below.

image

@aj-stein-nist aj-stein-nist merged commit f159b28 into main Sep 28, 2023
1 check passed
@nikitawootten-nist nikitawootten-nist deleted the chore-update-triage-board-automation branch September 28, 2023 14:08
@nikitawootten-nist
Copy link
Contributor

@aj-stein-nist should we replicate this workflow across the other OSCAL-umbrella repositories? If so, do the needed COMMIT_TOKEN permissions exist for each of them? (-Pages, -Reference, --content, -xslt?)

@aj-stein-nist
Copy link
Contributor Author

@aj-stein-nist should we replicate this workflow across the other OSCAL-umbrella repositories? If so, do the needed COMMIT_TOKEN permissions exist for each of them? (-Pages, -Reference, --content, -xslt?)

That was my intent for only the core projects for now. Are you volunteering to help? (Tokens were adjusted this morning, just need to send out PRs. 😎)

@nikitawootten-nist
Copy link
Contributor

That was my intent for only the core projects for now. Are you volunteering to help? (Tokens were adjusted this morning, just need to send out PRs. 😎)

Yeah I can submit the core PRs

@iMichaela
Copy link
Contributor

@aj-stein-nist and team - do we want to have it further discussed and have the team trained tomorrow during our lunch and learn, unless there is no other topic more important.

@aj-stein-nist
Copy link
Contributor Author

@aj-stein-nist and team - do we want to have it further discussed and have the team trained tomorrow during our lunch and learn, unless there is no other topic more important.

Completely fine with that and I agree. 👍

Copy link
Contributor

@Arminta-Jenkins-NIST Arminta-Jenkins-NIST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Reviewed.

nikitawootten-nist added a commit to usnistgov/OSCAL-Pages that referenced this pull request Sep 28, 2023
Following usnistgov/OSCAL#1936, add workflow to add new issues to the board automatically.
nikitawootten-nist added a commit to usnistgov/oscal-content that referenced this pull request Sep 28, 2023
Following usnistgov/OSCAL#1936, add workflow to add new issues to the board automatically.
nikitawootten-nist added a commit to nikitawootten-nist/oscal-cli that referenced this pull request Sep 28, 2023
Following usnistgov/OSCAL#1936, add workflow to add new issues to the board automatically
nikitawootten-nist added a commit to nikitawootten-nist/liboscal-java that referenced this pull request Sep 28, 2023
Following usnistgov/OSCAL#1936, add workflow to add new issues to the board automatically.
aj-stein-nist pushed a commit to usnistgov/oscal-content that referenced this pull request Sep 28, 2023
Following usnistgov/OSCAL#1936, add workflow to add new issues to the board automatically.
aj-stein-nist pushed a commit to usnistgov/oscal-cli that referenced this pull request Sep 28, 2023
Following usnistgov/OSCAL#1936, add workflow to add new issues to the board automatically
aj-stein-nist pushed a commit to usnistgov/liboscal-java that referenced this pull request Sep 28, 2023
Following usnistgov/OSCAL#1936, add workflow to add new issues to the board automatically.
aj-stein-nist pushed a commit to usnistgov/OSCAL-Pages that referenced this pull request Sep 28, 2023
Following usnistgov/OSCAL#1936, add workflow to add new issues to the board automatically.
nikitawootten-nist added a commit to usnistgov/OSCAL-Pages that referenced this pull request Nov 20, 2023
Following usnistgov/OSCAL#1936, add workflow to add new issues to the board automatically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Experience Issues around enhancing and optimizing work for development of NIST OSCAL artifacts Scope: CI/CD Enhancements to the project's Continuous Integration and Continuous Delivery pipeline.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants