-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move web content from OSCAL, and other streamlining. (Revised for Release) #1856
Move web content from OSCAL, and other streamlining. (Revised for Release) #1856
Conversation
- Content was deleted and distributed between OSCAL-Pages and OSCAL-Reference. - Unnecessary scripts and code were pruned from the repo. - Workflows were reduced as necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am very very happy with this. I will test more but I assume we need to answer the one big question before moving forward.
.gitmodules
Outdated
[submodule "build/metaschema"] | ||
path = build/metaschema | ||
url = https://github.com/usnistgov/metaschema.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe blocking 🤷: we still need to figure out this piece (stick with this, move to metaschema-xslt in the same PR) before we can formally, merge, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take guidance here. I'm not quite as confident on the best course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikitawootten-nist with usnistgov/metaschema-xslt#45 on the way and close to setting off the baking timer in the oven, I assume we are close to ready to switch out this sprint?
…nverter (#1849) * Replaced `metaschema` submodule with `metaschema-xslt` * The `metaschema-xslt` version also fixes #1849 * Removed all bespoke scripts and replaced them with Makefile targets * Changed CI infrastructure to use the new Makefile scripts * Removed Dockerfile and infrastructure as it is no longer needed * Changed model version to `1.1.0` Co-authored-by: Wendell Piez <[email protected]> Co-authored-by: Dmitry Cousin <[email protected]> Co-authored-by: Chris Compton <[email protected]> Co-authored-by: A.J. Stein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on previous discussions we've had, this all looks great!
Committer Notes
This is a corrected PR based on the issues around #1824.
In support of Issue #1802
Currently in rapid prototype mode with the team.
Remaining to determine:
Benefits:
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features:
Have you written new tests for your core changes, as applicable?A.J. is waving this, N/A.Have you included examples of how to use your new feature(s)?A.J. is waving this, N/A.