Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build container for XSpec testing for fork-based PRs #1817

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Jun 16, 2023

Committer Notes

As it stands, since we are evaluating using the Docker Hub registry that is not public to facilitate NIST Team development to be more efficient for local and remote testing. As this container may not exist at first commit of branch, disable on fork-based PRs for now.

Material to #1814 but does not close it.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

As it stands, since we are evaluating using the Docker Hub registry
that is not public to facilitate NIST Team development to be more
efficient for local and remote testing. As this container may not
exist at first commit of branch, disable on fork-based PRs for now.
@aj-stein-nist aj-stein-nist requested review from nikitawootten-nist and a team June 16, 2023 20:20
@aj-stein-nist aj-stein-nist self-assigned this Jun 16, 2023
@nikitawootten-nist
Copy link
Contributor

So to be pedantic, the image isn't actually being built (due to current issues with the image see #1814) but rather pulled from a currently private registry. I think this is a good stopgap but I hope with the improvements coming in #1814 forks can opt for the "build on the fly" variant as needed.

@aj-stein-nist
Copy link
Contributor Author

So to be pedantic, the image isn't actually being built (due to current issues with the image see #1814) but rather pulled from a currently private registry. I think this is a good stopgap but I hope with the improvements coming in #1814 forks can opt for the "build on the fly" variant as needed.

That's fair, sorry. I thought it will attempt to build and push to the registry as needed with the shell script though depending on the branch and existing cached version, am I mistaken?

@aj-stein-nist aj-stein-nist merged commit b497933 into develop Jun 23, 2023
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jun 29, 2023
As it stands, since we are evaluating using the Docker Hub registry
that is not public to facilitate NIST Team development to be more
efficient for local and remote testing. As this container may not
exist at first commit of branch, disable on fork-based PRs for now.
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jul 10, 2023
As it stands, since we are evaluating using the Docker Hub registry
that is not public to facilitate NIST Team development to be more
efficient for local and remote testing. As this container may not
exist at first commit of branch, disable on fork-based PRs for now.
@aj-stein-nist aj-stein-nist added this to the v1.1.0 milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants