Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing $ in Linux build setup steps #1779

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

laurelmay
Copy link
Contributor

@laurelmay laurelmay commented May 3, 2023

Committer Notes

The steps cannot be copied and pasted as-is because the chown command
is missing a $ for the USER variable for the group argument. This
also adds quotation marks around the variables.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

The steps cannot be copied and pasted as-is because the `chown` command
is missing a `$` for the `USER` variable for the group argument. This
also adds quotation marks around the variables.
Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you for your contribution, @kylelaker.

@aj-stein-nist
Copy link
Contributor

Thanks again, apologies for not merging this sooner.

@aj-stein-nist aj-stein-nist merged commit 93d91f9 into usnistgov:develop Jun 16, 2023
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jun 29, 2023
The steps cannot be copied and pasted as-is because the `chown` command
is missing a `$` for the `USER` variable for the group argument. This
also adds quotation marks around the variables.
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jul 10, 2023
The steps cannot be copied and pasted as-is because the `chown` command
is missing a `$` for the `USER` variable for the group argument. This
also adds quotation marks around the variables.
@aj-stein-nist aj-stein-nist added this to the v1.1.0 milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants