Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker container build for local dev and debugging #1598

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Dec 30, 2022

Committer Notes

Fix issue reported in #1597.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@aj-stein-nist aj-stein-nist self-assigned this Dec 30, 2022
If the TLS cert is bad, it will break local build just like
maven building Java deps in GHA.
@aj-stein-nist
Copy link
Contributor Author

Will also add the fix for #1600 here as it is in the same spot and make it easier to group these related changes together.

@david-waltermire david-waltermire merged commit eff9ce3 into usnistgov:develop Jan 9, 2023
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jan 10, 2023
* Fix Dockerfile multi-stage builds, closes usnistgov#1597.

* Add maven.restlet.org workaround.

If the TLS cert is bad, it will break local build just like
maven building Java deps in GHA.

* Fix directory safety for doctor, closes usnistgov#1600.

* Somehow, docs/run-server.sh set to non-executable again.
@david-waltermire david-waltermire linked an issue Jan 12, 2023 that may be closed by this pull request
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Feb 6, 2023
* Fix Dockerfile multi-stage builds, closes usnistgov#1597.

* Add maven.restlet.org workaround.

If the TLS cert is bad, it will break local build just like
maven building Java deps in GHA.

* Fix directory safety for doctor, closes usnistgov#1600.

* Somehow, docs/run-server.sh set to non-executable again.
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jun 29, 2023
* Fix Dockerfile multi-stage builds, closes usnistgov#1597.

* Add maven.restlet.org workaround.

If the TLS cert is bad, it will break local build just like
maven building Java deps in GHA.

* Fix directory safety for doctor, closes usnistgov#1600.

* Somehow, docs/run-server.sh set to non-executable again.
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jul 10, 2023
* Fix Dockerfile multi-stage builds, closes usnistgov#1597.

* Add maven.restlet.org workaround.

If the TLS cert is bad, it will break local build just like
maven building Java deps in GHA.

* Fix directory safety for doctor, closes usnistgov#1600.

* Somehow, docs/run-server.sh set to non-executable again.
@aj-stein-nist aj-stein-nist added this to the v1.1.0 milestone Jul 27, 2023
aj-stein-nist added a commit to galtm/OSCAL that referenced this pull request Sep 28, 2023
* Fix Dockerfile multi-stage builds, closes usnistgov#1597.

* Add maven.restlet.org workaround.

If the TLS cert is bad, it will break local build just like
maven building Java deps in GHA.

* Fix directory safety for doctor, closes usnistgov#1600.

* Somehow, docs/run-server.sh set to non-executable again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Container and Newer Git Enforce Safe Directory Checks
2 participants