-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Docker container build for local dev and debugging #1598
Merged
david-waltermire
merged 4 commits into
usnistgov:develop
from
aj-stein-nist:1597-fix-docker-container-build
Jan 9, 2023
Merged
Fix Docker container build for local dev and debugging #1598
david-waltermire
merged 4 commits into
usnistgov:develop
from
aj-stein-nist:1597-fix-docker-container-build
Jan 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aj-stein-nist
force-pushed
the
1597-fix-docker-container-build
branch
from
December 30, 2022 20:43
e5087fa
to
00e1586
Compare
If the TLS cert is bad, it will break local build just like maven building Java deps in GHA.
This was referenced Jan 3, 2023
Remove invalid profiles with incorrect imports for certain Rev5 profiles
usnistgov/oscal-content#169
Merged
Will also add the fix for #1600 here as it is in the same spot and make it easier to group these related changes together. |
david-waltermire
approved these changes
Jan 9, 2023
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jan 10, 2023
* Fix Dockerfile multi-stage builds, closes usnistgov#1597. * Add maven.restlet.org workaround. If the TLS cert is bad, it will break local build just like maven building Java deps in GHA. * Fix directory safety for doctor, closes usnistgov#1600. * Somehow, docs/run-server.sh set to non-executable again.
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Feb 6, 2023
* Fix Dockerfile multi-stage builds, closes usnistgov#1597. * Add maven.restlet.org workaround. If the TLS cert is bad, it will break local build just like maven building Java deps in GHA. * Fix directory safety for doctor, closes usnistgov#1600. * Somehow, docs/run-server.sh set to non-executable again.
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jun 29, 2023
* Fix Dockerfile multi-stage builds, closes usnistgov#1597. * Add maven.restlet.org workaround. If the TLS cert is bad, it will break local build just like maven building Java deps in GHA. * Fix directory safety for doctor, closes usnistgov#1600. * Somehow, docs/run-server.sh set to non-executable again.
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jul 10, 2023
* Fix Dockerfile multi-stage builds, closes usnistgov#1597. * Add maven.restlet.org workaround. If the TLS cert is bad, it will break local build just like maven building Java deps in GHA. * Fix directory safety for doctor, closes usnistgov#1600. * Somehow, docs/run-server.sh set to non-executable again.
aj-stein-nist
added a commit
to galtm/OSCAL
that referenced
this pull request
Sep 28, 2023
* Fix Dockerfile multi-stage builds, closes usnistgov#1597. * Add maven.restlet.org workaround. If the TLS cert is bad, it will break local build just like maven building Java deps in GHA. * Fix directory safety for doctor, closes usnistgov#1600. * Somehow, docs/run-server.sh set to non-executable again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Fix issue reported in #1597.
All Submissions:
"?
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features:
Have you added an explanation of what your changes do and why you'd like us to include them?Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.