Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding resource-fragment flag to link #1527

Merged

Conversation

david-waltermire
Copy link
Contributor

Defined a constraint to validate the allowed characters for a fragment. Resolves #756.

Committer Notes

Added a new flag to link name resource-fragment to indicate the URI fragment to append to any rlink associated with the referenced resource.
Resolves #756.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@david-waltermire david-waltermire changed the title Added resource-fragment flag to link. Adding resource-fragment flag to link Oct 28, 2022
@david-waltermire david-waltermire linked an issue Oct 28, 2022 that may be closed by this pull request
3 tasks
Defined a constraint to validate the allowed characters for a fragment.
Resolves usnistgov#756.
Copy link
Contributor

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice thanks Dave!

Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. LGTM, I had to read RFC3986 3.5 more generally and experiment with regex to make sure I am understood the constraint aligns with intent in the docs.

@aj-stein-nist aj-stein-nist merged commit a52aa15 into usnistgov:develop Nov 1, 2022
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jan 10, 2023
Defined a constraint to validate the allowed characters for a fragment.
Resolves usnistgov#756.
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Feb 6, 2023
Defined a constraint to validate the allowed characters for a fragment.
Resolves usnistgov#756.
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jun 29, 2023
Defined a constraint to validate the allowed characters for a fragment.
Resolves usnistgov#756.
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jul 10, 2023
Defined a constraint to validate the allowed characters for a fragment.
Resolves usnistgov#756.
@aj-stein-nist aj-stein-nist added this to the v1.1.0 milestone Jul 27, 2023
aj-stein-nist pushed a commit to galtm/OSCAL that referenced this pull request Sep 28, 2023
Defined a constraint to validate the allowed characters for a fragment.
Resolves usnistgov#756.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancing 'link' to indicate internal targets in a 'resource'
3 participants