Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken Booleans Only in workflow_call Conditional Cheecks #1236

Commits on May 6, 2022

  1. Boolean handling workaround for workflow_call vs workflow_dispatch bug.

    This fix will resolve the issue noticed in the runs post release prep.
    
    https://github.com/usnistgov/OSCAL/runs/6311164174
    https://github.com/usnistgov/OSCAL/runs/6311163976
    
    This is a workaround report in this thread.
    
    community/community#9343 (comment)
    
    It pertains to this issue, which has yet to be fixed in GitHub Actions
    runners that exhibit a difference in behavior for the same boolean input
    being treated as a string in a `workflow_dispatch` `inputs`
    (i.e. `github.event.inputs.*`) even if `type: boolean` is set but
    behaves properly as intended for `workflow_call` `inputs`
    (`inputs.*` which are different in the object graph) and treated as bools
    through and through. This is reported in actions/runner#1483.
    
    To resolve this, the buggy `workflow_dispatch` `github.event.inputs.*`
    will be left with the workaround as-is, conditional checking the values
    as strings, but we revert the changes for `workflow_call` `inputs.*` and
    leave them like before until actions/runner#1483 is resolved.
    aj-stein-nist committed May 6, 2022
    Configuration menu
    Copy the full SHA
    b53f152 View commit details
    Browse the repository at this point in the history