Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarified use of set-parameter and how to determine the effective value #1234

Merged
merged 1 commit into from
May 5, 2022
Merged

clarified use of set-parameter and how to determine the effective value #1234

merged 1 commit into from
May 5, 2022

Conversation

david-waltermire
Copy link
Contributor

@david-waltermire david-waltermire commented May 5, 2022 •
edited
Loading

Committer Notes

Clarified use of set-parameter and how to determine the effective value. Resolves #1206.

All Submissions:

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@david-waltermire david-waltermire force-pushed the issue1206-clarify-set-parameter branch from 6ae664e to 9207c95 Compare May 5, 2022 12:35
@david-waltermire david-waltermire linked an issue May 5, 2022 that may be closed by this pull request
set-parameter in the context of an SSP is ambiguously defined #1206
Closed
@david-waltermire david-waltermire added this to the OSCAL 1.0.3 milestone May 5, 2022
aj-stein-nist
aj-stein-nist approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GaryGapinski
GaryGapinski approved these changes May 5, 2022
View reviewed changes
Copy link

@GaryGapinski GaryGapinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@david-waltermire david-waltermire force-pushed the issue1206-clarify-set-parameter branch from 9207c95 to 59f9f12 Compare May 5, 2022 16:32
@david-waltermire david-waltermire merged commit 2401beb into usnistgov:release-1.0 May 5, 2022
@david-waltermire david-waltermire deleted the issue1206-clarify-set-parameter branch May 5, 2022 16:39
david-waltermire added a commit that referenced this pull request May 5, 2022
@david-waltermire
Clarified use of set-parameter and how to determine the effective val…
55c035b 
…ue. Resolves #1206. (#1234)
Rene2mt pushed a commit to Rene2mt/OSCAL that referenced this pull request May 17, 2022
@david-waltermire @Rene2mt
Clarified use of set-parameter and how to determine the effective val…
dee4ad9 
…ue. Resolves usnistgov#1206. (usnistgov#1234)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj-stein-nist aj-stein-nist aj-stein-nist approved these changes

@GaryGapinski GaryGapinski GaryGapinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
OSCAL 1.0.3
Development

Successfully merging this pull request may close these issues.

set-parameter in the context of an SSP is ambiguously defined
3 participants
@david-waltermire @GaryGapinski @aj-stein-nist