Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name typo from prop to props #1148

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

guyzyl
Copy link
Contributor

@guyzyl guyzyl commented Feb 22, 2022

Committer Notes

In all metaschemas, the name props is used to signify the list of metadata properties.
This PR fixes an obvious typo in the assessment results metaschema where the name prop is used instead of props.

This will most likely break backwards compatibility, but since this is an obvious typo/fix I think it is worth considering for versions earlier than v2.0.

All Submissions:

  • Have you selected the correct base branch per Contributing guidance?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

@david-waltermire david-waltermire added this to the OSCAL 1.0.2 milestone Feb 25, 2022
@david-waltermire david-waltermire self-assigned this Feb 25, 2022
@david-waltermire david-waltermire changed the base branch from develop to release-1.0 February 25, 2022 22:13
Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@david-waltermire david-waltermire merged commit c733fad into usnistgov:release-1.0 Feb 25, 2022
david-waltermire pushed a commit that referenced this pull request Feb 26, 2022
stephenbanghart pushed a commit to stephenbanghart/OSCAL that referenced this pull request Mar 14, 2022
iMichaela pushed a commit to iMichaela/OSCAL that referenced this pull request Apr 7, 2022
Rene2mt pushed a commit to Rene2mt/OSCAL that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants