Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra > which shows in the built schemas #1147

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Remove extra > which shows in the built schemas #1147

merged 1 commit into from
Feb 25, 2022

Conversation

guyzyl
Copy link
Contributor

@guyzyl guyzyl commented Feb 22, 2022 •
edited by david-waltermire
Loading

Committer Notes

Similarly to PR #1133, I came across 3 more place where there's an extra closing triangle bracket (>) that shows up in the built schemas.
This time I did a global search in the metaschemas for >>, so there aren't suppose to be anymore places where this occurs.

All Submissions:

  • Have you selected the correct base branch per Contributing guidance?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

david-waltermire
david-waltermire approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@david-waltermire david-waltermire changed the base branch from develop to release-1.0 February 25, 2022 22:26
@david-waltermire david-waltermire added this to the OSCAL 1.0.2 milestone Feb 25, 2022
@david-waltermire david-waltermire merged commit 0b23c6d into usnistgov:release-1.0 Feb 25, 2022
david-waltermire pushed a commit that referenced this pull request Feb 26, 2022
@guyzyl @secautobuilder
Remove extra > which shows in the built schemas (#1147)
907985b
oscalbuilder pushed a commit that referenced this pull request Feb 26, 2022
publish: Remove extra > which shows in the built schemas (#1147)
feb3394 
generated from commit 907985b
stephenbanghart pushed a commit to stephenbanghart/OSCAL that referenced this pull request Mar 14, 2022
@guyzyl @canb227
Remove extra > which shows in the built schemas (usnistgov#1147)
b5389a5
iMichaela pushed a commit to iMichaela/OSCAL that referenced this pull request Apr 7, 2022
@guyzyl @iMichaela
Remove extra > which shows in the built schemas (usnistgov#1147)
138ec52
Rene2mt pushed a commit to Rene2mt/OSCAL that referenced this pull request May 17, 2022
@guyzyl @Rene2mt
Remove extra > which shows in the built schemas (usnistgov#1147)
f36a2c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-waltermire david-waltermire david-waltermire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
OSCAL 1.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@guyzyl @david-waltermire