Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Metaschema Enhancements Needed for Rule Construct in Component Definition #1124

Closed
wants to merge 5 commits into from
Closed

[WIP] Metaschema Enhancements Needed for Rule Construct in Component Definition #1124

wants to merge 5 commits into from

Conversation

aj-stein-nist
Copy link
Contributor

Committer Notes

These are examples of metaschema model changes that will be required for #1058, and to support example document instances as seen in usnistgov/oscal-content#94.

NOTE: These are labelled WIP (Work In Progress) and are subject to change. Please report feedback on the issue, but also check for updates to the shape of the code as it changes.

All Submissions:

  • Have you selected the correct base branch per Contributing guidance?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.
  • Have you written new tests for your core changes, as applicable?

david-waltermire and others added 5 commits January 31, 2022 08:54
@david-waltermire
Release 1.0 metaschema adjustments (#1065)
51da183 
* Many fixes to the constraints in the OSCAL metaschemas to repair broken Metapaths.
* fixing defects in metaschema constraints
* Updating to latest Metaschema toolchain. Removed use of the "require" constraint.
* updating readme with current links
@aj-stein-nist
Add basic shape of update rule construct.
bfaa6d0
@aj-stein-nist
Make rule's activity an optional scalar list, 0 to many.
5c0626e
@aj-stein-nist
Alias activity->condition evaluator with a use-name directive.
d6ed244
@aj-stein-nist
Switch from condition-evaluator(s)->condition-test(s).
4c31de2
@aj-stein-nist aj-stein-nist self-assigned this Feb 3, 2022
@aj-stein-nist aj-stein-nist changed the title Issue 1058 rules metaschema draft [WIP] Metaschema Enhancements Needed for Rule Construct in Component Definition Feb 3, 2022
@aj-stein-nist aj-stein-nist linked an issue Feb 3, 2022 that may be closed by this pull request
Support for "Rules" in OSCAL Models #1058
Open
12 tasks
@aj-stein-nist aj-stein-nist added the Discussion Needed This issues needs to be reviewed by the OSCAL development team. label Feb 3, 2022
@aj-stein-nist aj-stein-nist mentioned this pull request Feb 3, 2022
Open
12 tasks
@david-waltermire david-waltermire marked this pull request as draft February 26, 2022 20:26
@aj-stein-nist
Copy link
Contributor Author

Per the request of Dave, I will close this and create the branch from my fork, per updated guidelines in #1157.

@aj-stein-nist aj-stein-nist deleted the issue-1058-rules-metaschema-draft branch March 4, 2022 14:17
@aj-stein-nist aj-stein-nist mentioned this pull request Mar 4, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-waltermire david-waltermire Awaiting requested review from david-waltermire

@wendellpiez wendellpiez Awaiting requested review from wendellpiez

Assignees

@aj-stein-nist aj-stein-nist

Labels
Discussion Needed This issues needs to be reviewed by the OSCAL development team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for "Rules" in OSCAL Models
2 participants
@aj-stein-nist @david-waltermire