Add support for yaml OSCAL files validation #1091
Conversation
There was a problem hiding this comment.
Thanks for a short and sweet contribution! I think it will depend on the view of @david-waltermire-nist and team, but thus far we had limited expectations of YAML support in our tooling, so I defer to him on whether we want/need it for now.
I also have one question about the library choice from previous experience.
This was done to address the concern raised in the PR - usnistgov#1091 (comment)
There was a problem hiding this comment.
Ok, I finally tested it out. This looks good to merge, @david-waltermire-nist. I am going to probably follow up in Gitter because the code is functional and works, but does indicate some errors in the JSON and Schema validation of official catalogs in usnistgov/oscal-content@a31b484. Will look into that and why it is different from our pipeline tooling with AJV. 🤷
|
@aj-stein-nist if any more work is needed on this script I'd be more than happy to work on it 🙂 |
Of course, the pinning requirement was simple and I updated in the branch and tested, it all worked. Just wanted to make sure we easily get tracking on specific deps and make sure we get automatic updates, I did similarly for our |
|
@david-waltermire-nist I think we can discuss later but you had asked yesterday afternoon if there were others ready for merge and ready for 1.0.1 release. This was small and points to the relevant branch, so this can probably go in too. |
david-waltermire
force-pushed
the
release-1.0
branch
from
e277f19
to
1697757
Compare
|
Need to rebase this one too. |
This was done to address the concern raised in the PR - usnistgov#1091 (comment)
aj-stein-nist
force-pushed
the
add-yaml-support-to-validator
branch
from
be7193c
to
82a37c3
Compare
|
And ... rebased! We're good to go. |
* Add support for yaml OSCAL files validation * Replace pyyaml library with ruamel.yaml This was done to address the concern raised in the PR - usnistgov#1091 (comment) * Pin specific versions of PyPI packages. Co-authored-by: Alexander Stein <[email protected]>
* Add support for yaml OSCAL files validation * Replace pyyaml library with ruamel.yaml This was done to address the concern raised in the PR - usnistgov#1091 (comment) * Pin specific versions of PyPI packages. Co-authored-by: Alexander Stein <[email protected]>
Add support for yaml OSCAL files validation
Committer Notes
Added support for yaml OSCAL files validation to
oscal-content-validatory.py.All Submissions: