Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes duplicate import #1077

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Removes duplicate import #1077

merged 1 commit into from
Jan 13, 2022

Conversation

flickerfly
Copy link
Contributor

@flickerfly flickerfly commented Dec 21, 2021 •
edited
Loading

Found import json was done twice. This removes the duplicate.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

@flickerfly
Removes duplicate import
a2cdcee 
Found import json was done twice. This removes the duplicate.
aj-stein-nist
aj-stein-nist reviewed Dec 21, 2021
View reviewed changes
Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @david-waltermire-nist will need to be the final person to merge (I am not a full admin), but short and sweet. Looks good to me. Nice catch!

iMichaela
iMichaela approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice catch.

@david-waltermire david-waltermire changed the base branch from main to release-1.0 January 13, 2022 17:45
@david-waltermire david-waltermire merged commit d8f765b into usnistgov:release-1.0 Jan 13, 2022
@aj-stein-nist aj-stein-nist mentioned this pull request Jan 13, 2022
Closed
2 tasks
david-waltermire pushed a commit that referenced this pull request Jan 26, 2022
@flickerfly @david-waltermire
Removes duplicate import (#1077)
2cd81e6 
Found import json was done twice. This removes the duplicate.
iMichaela pushed a commit to iMichaela/OSCAL that referenced this pull request Apr 7, 2022
@flickerfly @iMichaela
Removes duplicate import (usnistgov#1077)
2388c0f 
Found import json was done twice. This removes the duplicate.
Rene2mt pushed a commit to Rene2mt/OSCAL that referenced this pull request May 17, 2022
@flickerfly @Rene2mt
Removes duplicate import (usnistgov#1077)
2e336e4 
Found import json was done twice. This removes the duplicate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj-stein-nist aj-stein-nist aj-stein-nist left review comments

@iMichaela iMichaela iMichaela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flickerfly @iMichaela @aj-stein-nist @david-waltermire