Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Review all models, address feedback, and make improvements #597

Closed
13 of 23 tasks
david-waltermire opened this issue Jan 9, 2020 · 7 comments
Closed
13 of 23 tasks
Labels
enhancement Epic A collection of issues to be worked on over a series of sprints model-refactor Used to mark issues related to model refactoring for the Metaschema v4 transition. Scope: Modeling Issues targeted at development of OSCAL formats User Story

Comments

@david-waltermire
Copy link
Contributor

david-waltermire commented Jan 9, 2020

User Story:

As an OSCAL developer, I need to address all received feedback on the OSCAL models and have confidence that the models are stable for the Milestone 3 release.

Goals:

This issue is tracking a series of issues dealing with review of the OSCAL models and making changes to the models based on the feedback we have recieved from the OSCAL community.

These issues are:

This also relates to the epic #257.

Once this work is completed we need to do a top-to-bottom review of all the models (#478) to make sure all models are consistent, well-defined, and all identifiable bugs are addressed.

Dependencies:

None

Acceptance Criteria

  • All OSCAL website and readme documentation affected by the changes in this issue have been updated. Changes to the OSCAL website can be made in the docs/content directory of your branch.
  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.
@david-waltermire david-waltermire added Epic A collection of issues to be worked on over a series of sprints Scope: Modeling Issues targeted at development of OSCAL formats labels Jan 9, 2020
@david-waltermire david-waltermire added this to the OSCAL 1.0 Milestone 3 milestone Jan 9, 2020
@brian-ruf brian-ruf mentioned this issue Jan 10, 2020
4 tasks
@david-waltermire
Copy link
Contributor Author

PR #607 addressed #528.

@david-waltermire
Copy link
Contributor Author

PR #608 addresses #551.

@david-waltermire
Copy link
Contributor Author

PR #609 addresses #568.

@david-waltermire
Copy link
Contributor Author

david-waltermire commented Jan 29, 2020

PR #619 addresses #552, #581, #587, #611, #612. This also partially addresses #498.

@brian-ruf
Copy link
Contributor

30-Jan-2020 Status

Continue to work issues in this epic. Made changes to several models in metaschema; however, data issues and PR #614 need to be addressed before those issues can be closed. See @david-waltermire-nist comment above.

@david-waltermire
Copy link
Contributor Author

david-waltermire commented Feb 4, 2020

PR #619 also addresses issues #535, #541 and #600.

@david-waltermire david-waltermire added the model-refactor Used to mark issues related to model refactoring for the Metaschema v4 transition. label Sep 11, 2020
@david-waltermire
Copy link
Contributor Author

The remaining work has either been pushed to a different release or has a dedicated issue. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Epic A collection of issues to be worked on over a series of sprints model-refactor Used to mark issues related to model refactoring for the Metaschema v4 transition. Scope: Modeling Issues targeted at development of OSCAL formats User Story
Projects
None yet
Development

No branches or pull requests

2 participants