Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile Check Schematron Enhancements Fail in GHA Due to Relative Path Issues #1603

Closed
aj-stein-nist opened this issue Jan 6, 2023 · 0 comments · Fixed by #1604
Closed
Assignees
Labels
Milestone

Comments

@aj-stein-nist
Copy link
Contributor

Describe the bug

OSCAL profile checks work some of the time after #1513 was merged into develop, but relative pathing issues with how our shell harness works with the presumed working directory is relative to the source file target of the transform. This exhibits inconsistent behavior between the docker-compose-based method, which uses a mount at "the current directory" mounted at /oscal in the container versus /github/workspace called at a different path without Docker used at all, so specific hard-coded relative paths cause errors.

This was discovered while continued worked on debugging usnistgov/oscal-content#139 to reproduce a bug, figure out, and finalize a solution for usnistgov/metaschema#235.

Who is the bug affecting

NIST OSCAL developers relying on Schematron to validate profiles, which will fail builds prematurely without Schematron validation taking place at all early in the process.

What is affected by this bug

CI/CD, Metaschema

How do we replicate this issue

  1. Review commit in example oscal-content branch for debugging: usnistgov/oscal-content@c790bc0
  2. Review CI/CD errors if they existed, but they have since expired. :-(

Expected behavior (i.e. solution)

Paths are handled correctly and validation completes without issue, only errors if validation errors occur and document instances need correcting.

Other comments

N/A

@aj-stein-nist aj-stein-nist self-assigned this Jan 6, 2023
@aj-stein-nist aj-stein-nist moved this from Todo to In Progress in NIST OSCAL Work Board Jan 6, 2023
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Jan 6, 2023
@aj-stein-nist aj-stein-nist moved this from In Progress to Under Review in NIST OSCAL Work Board Jan 6, 2023
@aj-stein-nist aj-stein-nist linked a pull request Jan 6, 2023 that will close this issue
6 tasks
@github-project-automation github-project-automation bot moved this from Under Review to Done in NIST OSCAL Work Board Jan 9, 2023
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Jan 10, 2023
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Feb 6, 2023
aj-stein-nist added a commit to aj-stein-nist/OSCAL that referenced this issue Jun 29, 2023
aj-stein-nist added a commit to aj-stein-nist/OSCAL that referenced this issue Jun 29, 2023
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Jul 10, 2023
@aj-stein-nist aj-stein-nist added this to the v1.1.0 milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment