Remarks fields in SSP defined as string instead of #field_oscal-metadata_remarks

[guyzyl]

Describe the bug

In the SSP schema, there are a 2 models that contain a remarks field that is defined with "type": "string" instead of "$ref": "#field_oscal-metadata_remarks"

The places are:

• #assembly_oscal-ssp_diagram
• #assembly_oscal-ssp_authorization-boundary

They should be updated to use #field_oscal-metadata_remarks.

What is affected by this bug?

The bug doesn't have a critical effect since #field_oscal-metadata_remarks is defined as a string, therefore there's no type mismatch.
It does however harm the conformity of the schema, and should be fixed.

Other Comments

I'd be happy to open a PR for this if this if this is approved as a bug.

[david-waltermire]

@guyzyl The SSP Metaschema needs to be updated for these. This will cause the JSON schema to be generated properly.

The following cases need to be update:

• OSCAL/src/metaschema/oscal_ssp_metaschema.xml

  Line 401 in c221bb1

  <define-field name="remarks" as-type="markup-multiline" in-xml="WITH_WRAPPER">

• OSCAL/src/metaschema/oscal_ssp_metaschema.xml

  Line 442 in c221bb1

  <define-field name="remarks" as-type="markup-multiline" in-xml="WITH_WRAPPER">

The should look like:

OSCAL/src/metaschema/oscal_ssp_metaschema.xml

Line 370 in c221bb1

<field ref="remarks" in-xml="WITH_WRAPPER"/>

You interested in submitting a PR to do this? Would you also be interested in checking and fixing any similar issues in the other metaschemas?

Never mind, I just noticed your PR #1138. I'll get this merged.