-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POAM Item should have a related-finding assembly #1120
Comments
I believe this could also be a link: Something like: link:
- rel: related-finding
href: source#finding-uuid |
Stepping back a little bit, lets envision creating a poam-item by including a {finding which refers to target, and/or observations and/or risks}, OR In both cases the related-observations and related-risks will be copied into the "observations" and "risks" assemblies in the POAM document. Likewise the related-findings should be copied into a "findings" assembly in the POAM document. This continues the theme of keeping the POAM document fairly self sufficient Using a link to other documents breaks the paradigm of keeping the POAM document fairly self sufficient. |
@vmangat - OSCAL's core traceability concept is based on exactly the opposite approach than the one you try to implement. The information is not re-copied between documents (OSCAL content) because the maintenance/updates of all documents will be a nightmare. Tools can bring the information in front of the user's eyes by extracting it from the OSCAL sources. |
@iMichaela We are by no means suggesting or supporting re-copying of information, i was making that comment based on the current design of poam-item, it will necessitate this. We are asking that Observations, Risks and Findings be treated the same and all 3 could be present in the poam-item. Finding is missing from poam-item as defined in v1.0.0 Happy to explain this in more detail if this issues can be scheduled for discussion a dev meeting. |
@vmangat We can add a |
We should also create an example of how to do this. |
|
Submitted PR to address this: #1478 An assembly was added for related-finding. |
Thank you for this change. It helps link poam-item to finding/target and finding/implementation-uuid without the use of additional props that FedRAMP had to introduce. |
* Add related finding assembly. #1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <[email protected]>
* Add related finding assembly. #1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <[email protected]>
* Add related finding assembly. #1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <[email protected]>
* Add related finding assembly. usnistgov#1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <[email protected]>
* Add related finding assembly. usnistgov#1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <[email protected]>
* Add related finding assembly. usnistgov#1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <[email protected]>
* Add related finding assembly. usnistgov#1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <[email protected]>
* Add related finding assembly. usnistgov#1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <[email protected]>
User Story:
As an OSCAL tool developer, it is a challenge to identify a "target" or the implementation-statement-uuid for a specific poam-item without traversing through the observations of the poam-item and then correlating these observations with the related-observations in the findings
Goals:
This can be implemented by including an assembly in poam-items as follows:
or
by use of a
link
withrel='related-finding'
.Dependencies:
None. This would be a backward compatible change that could be added in v1.0.2
Acceptance Criteria
{The items above are general acceptance criteria for all User Stories. Please describe anything else that must be completed for this issue to be considered resolved.}
The text was updated successfully, but these errors were encountered: