Migration from satori/go.uuid #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This PR also includes the changes in #124 so @bepitulaz feel free to merge this one and close the other one if you approve both changes. |
|
@pablojimpas thanks. Ok. I'll close that one. Google uuid seems better. We can try that one. |
yasintze
pushed a commit
that referenced
this pull request
Sep 5, 2021
* Create codeql-analysis.yml * satori/go.uuid replacement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an actively maintain fork of this package at https://pkg.go.dev/github.com/gofrs/uuid that is a drop-in replacement.
The original one has important issues unresolved and it's not maintained anymore.
satori/go.uuid#103
satori/go.uuid#84
Maybe it will be better to migrate to https://github.com/google/uuid because it's backed by Google but it will require a little bit of code re-write.