Updated translations #725
Merged
Updated translations #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will do. What do I add? not use to github.
…________________________________
From: Kai <[email protected]>
Sent: 03 June 2017 14:57
To: userfrosting/UserFrosting
Cc: abdullahseba; Mention
Subject: [userfrosting/UserFrosting] Updated translations (#725)
Updated german translations and moved some texts to the translation files. @lcharette<https://github.com/lcharette> could you also update the french files? @abdullahseba<https://github.com/abdullahseba> and you the arab?
________________________________
You can view, comment on, or merge this pull request online at:
#725
Commit Summary
* Updated / added translations
* Added fruther trasnlations
File Changes
* M app/sprinkles/account/locale/ar/messages.php<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-0> (6)
* M app/sprinkles/account/locale/de_DE/messages.php<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-1> (29)
* M app/sprinkles/account/locale/en_US/messages.php<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-2> (16)
* M app/sprinkles/account/locale/fr_FR/messages.php<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-3> (6)
* M app/sprinkles/account/locale/pt_PT/messages.php<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-4> (6)
* M app/sprinkles/account/templates/pages/error/compromised.html.twig<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-5> (6)
* M app/sprinkles/account/templates/pages/register.html.twig<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-6> (6)
* M app/sprinkles/account/templates/pages/set-password.html.twig<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-7> (18)
* M app/sprinkles/account/templates/pages/sign-in.html.twig<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-8> (4)
* M app/sprinkles/admin/locale/de_DE/messages.php<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-9> (17)
* M app/sprinkles/admin/locale/en_US/messages.php<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-10> (1)
* M app/sprinkles/admin/templates/components/tables/table-paginated.html.twig<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-11> (8)
* M app/sprinkles/admin/templates/pages/dashboard.html.twig<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-12> (8)
* M app/sprinkles/admin/templates/pages/permission.html.twig<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-13> (2)
* M app/sprinkles/core/locale/de_DE/messages.php<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-14> (20)
* M app/sprinkles/core/locale/de_DE/validate.php<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-15> (7)
* M app/sprinkles/core/locale/en_US/messages.php<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-16> (19)
* M app/sprinkles/core/templates/pages/index.html.twig<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-17> (2)
* M app/sprinkles/core/templates/pages/legal.html.twig<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-18> (2)
* M app/sprinkles/core/templates/pages/privacy.html.twig<https://github.com/userfrosting/UserFrosting/pull/725/files#diff-19> (2)
Patch Links:
* https://github.com/userfrosting/UserFrosting/pull/725.patch
* https://github.com/userfrosting/UserFrosting/pull/725.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#725>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AYXX0iDc2Hik0gk1VYmetD8llBaJDgmuks5sAWY9gaJpZM4NvF3T>.
|
|
In
In
In
That should by all from my changes 😀 but there are also some strings added recently from alex etc. for exampe in |
|
Thanks! will try to do it soon. |
|
Thanks! This can be merged in a hotfix. |
alexweissman
reviewed
Jun 9, 2017
| <p class="login-box-msg"><strong>Create Password</strong></p> | ||
| <p class="login-box-msg">Welcome to {{site.title}}! Please create a password for your new account.</p> | ||
| <p class="login-box-msg"><strong>{{translate("PASSWORD.CREATE")}}</strong></p> | ||
| <p class="login-box-msg">{{translate("WELCOME_TO", {'title': site.title})}} {{translate("PASSWORD.CREATE.PAGE")}}</p> |
There was a problem hiding this comment.
Would this be a good spot to use compound i18n keys? PASSWORD.CREATE.PAGE could reference the WELCOME_TO key.
There was a problem hiding this comment.
Sounds good :) will try that
lcharette
reviewed
Jun 9, 2017
| <p> | ||
| It doesn't look like any features have been set up for this account...yet. Maybe they haven't been implemented yet, or maybe someone forgot to give you access. Either way, we're glad to have you aboard! | ||
| {{translate("NO_FEATURES_YET")}} |
There was a problem hiding this comment.
Not sure this need translating, at least not in core sprinkles where the key will stay forever. This sentence will be changed by devs in 95% of cases maybe...
|
Updated mine (I think) hope I did it right.... |
| @@ -82,7 +82,7 @@ | |||
| <button type="submit" class="btn btn-block btn-primary">{{translate('REGISTER_ME')}}</button> | |||
| </div> | |||
| <div style="padding-top: 10px;"> | |||
| Already have an account? <a href="{{site.uri.public}}/account/sign-in">Sign in here.</a> | |||
| {{translate('SIGN_IN_HERE', {'url' : '#{site.uri.public}/account/sign-in'}) | raw}} | |||
There was a problem hiding this comment.
This doesn't seem to work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated german translations and moved some texts to the translation files. @lcharette could you also update the french files? @abdullahseba and you the arab ones?