Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for FindUniqueTest when class mappings are changed #1201

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

archey347
Copy link

FindUniqueTest fails in the accounts sprinkle when class mappings are changed for user and group.

@archey347 archey347 changed the base branch from master to hotfix February 27, 2022 04:13
@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #1201 (dc067af) into hotfix (20192dc) will decrease coverage by 2.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             hotfix    #1201      +/-   ##
============================================
- Coverage     70.68%   68.34%   -2.34%     
  Complexity     1985     1985              
============================================
  Files           173      169       -4     
  Lines          6905     6641     -264     
============================================
- Hits           4881     4539     -342     
- Misses         2024     2102      +78     
Impacted Files Coverage Δ
...rinkles/account/src/Database/Models/Permission.php 60.00% <0.00%> (-7.86%) ⬇️
app/sprinkles/admin/src/Sprunje/UserSprunje.php 16.66% <0.00%> (-3.75%) ⬇️
...pp/sprinkles/account/src/Twig/AccountExtension.php 76.47% <0.00%> (-3.53%) ⬇️
app/sprinkles/core/src/Csrf/SlimCsrfProvider.php 26.92% <0.00%> (-2.71%) ⬇️
app/sprinkles/account/src/Database/Models/User.php 75.00% <0.00%> (-2.40%) ⬇️
...rinkles/account/src/Repository/TokenRepository.php 62.06% <0.00%> (-1.87%) ⬇️
.../account/src/ServicesProvider/ServicesProvider.php 81.10% <0.00%> (-1.30%) ⬇️
app/sprinkles/core/src/Router.php 72.00% <0.00%> (-1.08%) ⬇️
...es/admin/src/ServicesProvider/ServicesProvider.php 89.47% <0.00%> (-1.01%) ⬇️
app/sprinkles/account/src/Account/Registration.php 74.69% <0.00%> (-0.89%) ⬇️
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20192dc...dc067af. Read the comment docs.

@lcharette lcharette merged commit 5a5eb3a into userfrosting:hotfix Mar 1, 2022
@lcharette
Copy link
Member

Thanks !

1 similar comment
@lcharette
Copy link
Member

Thanks !

@lcharette lcharette added this to the 4.6.5 milestone Jul 1, 2022
@lcharette lcharette added the testing Related to automated testing label Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Related to automated testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants