Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreign Key constraint fails when an admin attempts to create a new user #1190

Merged
merged 2 commits into from
Jan 16, 2022

Conversation

avsdev-cw
Copy link
Contributor

Back in 2019 a PR was approved to allow "No Group". It looks like the ability for admins to create users without a group was overlooked.

lcharette and others added 2 commits December 14, 2021 20:11
Back in 2019 a PR was approved to allow "No Group". It looks like the ability for admins to create users without a group was overlooked.
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #1190 (c8b4f74) into master (15d713a) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1190      +/-   ##
============================================
- Coverage     70.69%   70.68%   -0.01%     
- Complexity     1983     1985       +2     
============================================
  Files           173      173              
  Lines          6903     6905       +2     
============================================
+ Hits           4880     4881       +1     
- Misses         2023     2024       +1     
Impacted Files Coverage Δ
.../sprinkles/admin/src/Controller/UserController.php 99.42% <50.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d713a...c8b4f74. Read the comment docs.

@lcharette lcharette changed the base branch from master to hotfix January 16, 2022 18:47
@lcharette lcharette merged commit cfbc49a into userfrosting:hotfix Jan 16, 2022
@lcharette lcharette added this to the 4.6.4 milestone Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants