Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing permission slug in Manage permissions modal #748

Closed
lcharette opened this issue Jun 27, 2017 · 3 comments
Closed

Missing permission slug in Manage permissions modal #748

lcharette opened this issue Jun 27, 2017 · 3 comments
Labels
confirmed bug Something isn't working
Milestone
4.1.xx

Comments

@lcharette
Copy link
Member

capture d ecran 2017-06-26 a 21 19 42
@lcharette lcharette added the confirmed bug Something isn't working label Jun 27, 2017
@lcharette lcharette added this to the 4.1.x milestone Jun 27, 2017
@alexweissman
Copy link
Member

Ok, I figured this out. This is my fault (and Handlebar's). I added a slug Handlebars helper in 4.1, and this collides with the slug parameter that we're trying to pass in.

@alexweissman
Copy link
Member

Oddly enough, the first place where I found this mentioned was here: adamrenklint/asimovjs.org#20

@alexweissman alexweissman mentioned this issue Jul 3, 2017
Closed
alexweissman added a commit that referenced this issue Jul 3, 2017
@alexweissman
Use this.slug to avoid conflict with helper names (#748)
7396a2c
@alexweissman
Copy link
Member

Fixed in 7396a2c. See #756 for discussion on the underlying issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed bug Something isn't working
Projects
None yet
Milestone
4.1.xx
Development

No branches or pull requests
2 participants
@lcharette @alexweissman