Function declaration typehinting for all classes and functions

[alexweissman]

PHP has function declaration typehinting for classes, arrays, and callables. Why aren't we using that consistently everywhere?

[Silic0nS0ldier]

Should definitely be used. It's an effective way to improve quality of code (in the worst cases) and can eliminate entire misguided debugging cycles.

Just keep in mind that string, int, float and bool are PHP 7 only.

[lcharette]

Just keep in mind that string, int, float and bool are PHP 7 only.

I knew there was something special regarding this and PHP 7...

I guess it's something that can either be changed once, or as we go. If we want to drop 4.1 soon, it could be done as we go further, or at least moved to a 4.1.x version (shouldn't be any breaking change...)

[lcharette]

I think I got most of it... I went thought all classes as pictured in 36affb0. Fixed the comments, classes and misc styling. Checked with Serenata in Atom and php-cs-fixer.

Two issues remains :

1. Some non existing classes in WhoopsRenderer
2. Serenata not being happy with this variable argument in ClassMapper

...but that's for another issue.

For now, we (and by we I mean @alexweissman) should probably setup StyleCI on this repo ❤️