Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whoops for error handling? #674

Closed
alexweissman opened this issue Mar 21, 2017 · 1 comment
Closed

Whoops for error handling? #674

alexweissman opened this issue Mar 21, 2017 · 1 comment
Labels
core feature request Feature request
Milestone
4.1.xx

Comments

@alexweissman
Copy link
Member

Seems like a pretty popular library, and would be one less thing we need to maintain:

https://github.com/filp/whoops
@alexweissman alexweissman added the core feature request Feature request label Mar 21, 2017
alexweissman added a commit that referenced this issue May 30, 2017
@alexweissman
implement renderer inspired by Whoops (#674)
50f0320
@alexweissman alexweissman added this to the 4.1.x milestone May 30, 2017
@alexweissman
Copy link
Member Author

It looks like it's not possible to simply plug Whoops into our exception-handling system; they each implement their own complete error-handling stack. I prefer our basic error-handling system because it allows you to map individual exception types to different handlers.

On the other hand, I do like Whoops' PrettyPageHandler, so I have adapted it as the WhoopsRenderer in our new Renderer system in v4.1. It looks great!

screen shot 2017-05-30 at 1 30 16 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core feature request Feature request
Projects
None yet
Milestone
4.1.xx
Development

No branches or pull requests
1 participant
@alexweissman