Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce 'debug' as an option for UF_MODE #653

Closed
Silic0nS0ldier opened this issue Feb 20, 2017 · 12 comments
Closed

Introduce 'debug' as an option for UF_MODE #653

Silic0nS0ldier opened this issue Feb 20, 2017 · 12 comments
Assignees
Labels
core feature request Feature request
Milestone

Comments

@Silic0nS0ldier
Copy link
Member

Currently there is a dev UF_MODE that favours itself to development. While this works good, sometimes we need more verbosity to track down the source of an error.

I suggest we introduce a third UF_MODE called debug that puts everything in debug mode.

It may also be of benefit to make it such that this mode can be used alongside other modes, such as production, to help isolate issues specific to that mode (since there are performance related differences).

@lcharette
Copy link
Member

Can't it be set in dev/production specific config files?

@alexweissman
Copy link
Member

I think that's @Silic0nS0ldier's point. We have a debug.php config file that just opens up the floodgates, turning on all debug settings.

@alexweissman alexweissman modified the milestone: 4.0 Mar 1, 2017
@anderson2927
Copy link

Nemesis, we meet again

@alexweissman alexweissman modified the milestones: 4.x, 4.1.x Jun 18, 2017
@Silic0nS0ldier
Copy link
Member Author

Noticed that UF has grown a testing.php. Would I be correct in assuming this knew file introduces the features wanted in a debug.php configuration?

@lcharette
Copy link
Member

testing is used to disable stuff like cache and displayErrorDetails when running PHP Unit tests

@Silic0nS0ldier
Copy link
Member Author

Ah. That clears things up.

@alexweissman
Copy link
Member

There's also a dev.php. Can we rename this to debug.php instead? So-called "dev" mode is really just the default mode.

@lcharette
Copy link
Member

Note that when Bakery creates app/.env, it set UF_MODE to "".

To make dev truly the default mode, bakery needs to be updated

@alexweissman
Copy link
Member

@lcharette
Copy link
Member

So-called "dev" mode is really just the default mode.

dev == default?

On a side note, It could be clearer for new dev if something was defined in .env instead of ""...

@alexweissman
Copy link
Member

default == default

My point is, there is no explicit "dev" mode right now. That dev.php should really be called debug.php.

@alexweissman alexweissman removed the V4 label Jul 14, 2017
@lcharette lcharette modified the milestones: 4.1.x, 4.2.0 Dec 16, 2017
@lcharette lcharette modified the milestones: 4.2.0, 4.3.0 Oct 13, 2018
@lcharette lcharette modified the milestones: 4.3.0, 4.4.0 Oct 20, 2018
@lcharette lcharette modified the milestones: 4.4.0, 4.2.0 Oct 28, 2018
@lcharette lcharette self-assigned this Oct 28, 2018
@lcharette
Copy link
Member

Done in ec508e0 for 4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core feature request Feature request
Projects
None yet
Development

No branches or pull requests

4 participants