Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UF5] AppController says "safe to be deleted", but this breaks 4 routes #1241

Closed
StrykeSlammerII opened this issue Feb 5, 2024 · 2 comments
Assignees
Labels
developer experience The one building with UF
Milestone

Comments

@StrykeSlammerII
Copy link

AppController class in the skeleton says it is "safe to be deleted", but doing so causes errors similar to Fatal error: Uncaught RuntimeException: Named route does not exist for name: index in /home/strike/Frosting/UF5-native/vendor/slim/slim/Slim/Routing/RouteCollector.php
chat link: https://chat.userfrosting.com/channel/support?msg=pCkTbS8m33m64qSjH

/, /legal, /about, and /privacy are the affected routes.

Most full sites will want to provide their own pages here, but dependent sprinkles should be able to use the defaults without including or overriding AppController.

@lcharette lcharette self-assigned this Feb 5, 2024
@lcharette lcharette moved this to Todo 5.1.0 in UserFrosting Task Planner Feb 5, 2024
@lcharette lcharette added the developer experience The one building with UF label Feb 5, 2024
@lcharette lcharette added this to the 5.1.0 milestone Feb 5, 2024
@lcharette
Copy link
Member

To fix, it should be documented in the skeleton that while these Controllers are safe to be deleted, there's also another step to delete the route.

Plus, index name route should not be required / hardcoded in the navigation template (or provide a fallback), so an exception is not thrown if the index route doesn't exist (or at least, a 404 page is thrown instead)

@lcharette lcharette modified the milestones: 5.1.0, 5.0.2 Feb 6, 2024
@lcharette lcharette moved this from Todo 5.1.0 to Todo 5.0.x in UserFrosting Task Planner Feb 6, 2024
@lcharette
Copy link
Member

Done for part one :)

@github-project-automation github-project-automation bot moved this from Todo 5.0.x to Done in UserFrosting Task Planner Feb 6, 2024
@lcharette lcharette moved this from Done (5.1) to Done in UserFrosting Task Planner Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience The one building with UF
Projects
Status: Done
Development

No branches or pull requests

2 participants