Skip to content

Commit

Permalink
Revert "gcab: ignore buildpaths error from sources"
Browse files Browse the repository at this point in the history
This reverts commit e11df06.

This isn't needed in scarthgap where buildpaths aren't in
default ERROR_QA and it's not a correct fix anyway, see
https://lists.openembedded.org/g/openembedded-devel/message/112048

This doesn't work with multilib where the package is named ${PN}-src
(e.g. lib32-gcab-src) and it's better to just lower buildpaths from
ERROR_QA to WARN_QA instead of skipping it completely, because it's
still an issue which should be fixed (at least to improve hashserv
efficiency if you don't care about reproducibility itself)

and commits in master:
https://git.openembedded.org/meta-openembedded/commit/?id=154f5bb1342739d88185ac0cce9c15b7b2958187
https://git.openembedded.org/meta-openembedded/commit/?id=6644c4a420db82da1ce71697ff889e7b1b6e41ad

Signed-off-by: Martin Jansa <[email protected]>
Signed-off-by: Armin Kuster <[email protected]>
  • Loading branch information
shr-project authored and akuster committed Sep 9, 2024
1 parent f88706f commit 1d85f63
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions meta-oe/recipes-gnome/gcab/gcab_1.6.bb
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,3 @@ PACKAGECONFIG[nls] = "-Dnls=true,-Dnls=false"
PACKAGECONFIG[tests] = "-Dtests=true -Dinstalled_tests=true,-Dtests=false -Dinstalled_tests=false"

BBCLASSEXTEND = "native"

# meson embeds absolute paths to generated files on purpose
INSANE_SKIP:gcab-src += "buildpaths"

0 comments on commit 1d85f63

Please sign in to comment.