settings.py: add 'proxy_images'

[zrose584]

No description provided.

[user234683]

May I ask, what's the intent of the setting (i.e., is the extra complexity really worth it)?

I left some feedback on the code for reference, but this sort of feature would be cleaner if it acted in server.py at the routing level. It should still route through the server itself but not through Tor, so that the browser doesn't send any identifying info to the image servers that it doesn't have to.

proxy_site could be replaced with an intermediate handler which checks the setting for lh3.googleusercontent.com, yt3.ggpht.com, and ytimg.com in server.py.

[zrose584]

The motivation stems from an addon I use, imagus.
It has handmade rules for ggpht.com and ytimg.com.
Porting those to youtube_local would risk inconsistency with the original/upstream rules.

It should still route through the server itself but not through Tor, so that the browser doesn't send any identifying info to the image servers that it doesn't have to.

No, that would defeat the purpose of this patch. Also I think it's unlikely they use (image) data requests for user identification.
And even if, I could use some header-manipulation addon to achieve what youtube_local does (it's just about the HTTP-Headers, right?).

[zrose584]

The addon uses element's src attribute, which is unchanged by a 302.
Can this be merged now?