Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs for compose ports and path routes #3833

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Added documentation describing the lagoon.service.usecomposeports label and how it can be used.

Also added documentation to describe path based routes and how to configure them.

Additionally, tweaked additional volumes to show how they can be used without a -persistent service type. Added a note that new projects should use non -persistent service types with additional volumes. As we should really promote this as the way to do persistent volumes instead of the older -persistent types.

Closing issues

closes #3832

@shreddedbacon shreddedbacon marked this pull request as ready for review October 30, 2024 04:14
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tobybellwood tobybellwood merged commit 3a29643 into main Oct 30, 2024
3 checks passed
@shreddedbacon shreddedbacon deleted the docs/ports-and-pathroutes branch October 31, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Document Multiple Ports for services
2 participants