Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: delete environment to log final deletion #3808

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Small change to the deleteEnvironment mutation to log if the actual deletion of the environment took place in the userActivity logger event message.

@shreddedbacon shreddedbacon added this to the 2.22.0 milestone Sep 17, 2024
@shreddedbacon shreddedbacon marked this pull request as ready for review September 17, 2024 23:59
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logs as expected - returning "deleted":true, once it's actually gone

@tobybellwood tobybellwood merged commit 9d9b5b4 into main Oct 22, 2024
1 check passed
@tobybellwood tobybellwood deleted the refactor-delete-environment branch October 22, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants