Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace REDIS_PORT to REDIS_SERVICE_PORT #1263

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Replace REDIS_PORT to REDIS_SERVICE_PORT #1263

merged 1 commit into from
Sep 23, 2019

Conversation

vincenzodnp
Copy link
Contributor

@vincenzodnp vincenzodnp commented Sep 23, 2019 •
edited
Loading

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

The REDIS_PORT environment variable is not a "port" but a TCP address.
While REDIS_SERVICE_PORT is a variable set by Kube service discovery, with the TCP port Redis service is listening to.

Changelog Entry

Improvement - Use of REDIS_SERVICE_PORT instead of REDIS_PORT (#1254)

Closing issues

closes #1254

@Schnitzel Schnitzel merged commit 489764e into master Sep 23, 2019
@Schnitzel Schnitzel added this to the v1.1.0 milestone Sep 27, 2019
@dasrecht dasrecht deleted the 1254-switch-REDIS_PORT-to-REDIS_SERVICE_PORT branch January 24, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schnitzel Schnitzel Schnitzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

REDIS_PORT is defined as a TCP address.
2 participants
@vincenzodnp @Schnitzel