Cache keycloak authz requests #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocketeerbkw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new RBAC system means the API queries keycloak for permissions. In cases where the API returns a lot of data, it can hammer keycloak with a lot of permission check requests. Since it's unlikely that a users permissions will change in the middle of an API request, we can cache the results per request.
Also added some better logging when keycloak auth requests fail.
Checklist
Explain the details for making this change. What existing problem does the pull request solve?
Changelog Entry
Bugfix - Fix API slowness by caching keycloak authz response per API request
Closing issues
N/A