Better docker-host pruning #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as they can limit the impact of the pruning.
…pruning the whole cache
Schnitzel
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Implemented the docker-host to be pruned from all images older than 7 days to make sure we don't have too much image buildup.
Additionally I implemented a cronjob that removes exited containers as I saw some of those were blocking the old prune job to work correctly as they still were holding the reference to those containers.
Changelog Entry
Improvement -
docker-hostpruning is more thorough by removing all images older than 7 days, additionally we take care of potentially exited containers that prevented cleanup (#1051)Closing issues
closes #1051