Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed document links #1037

Merged
merged 3 commits into from
Apr 20, 2019
Merged

fixed document links #1037

merged 3 commits into from
Apr 20, 2019

Conversation

akosmaroy
Copy link

fixes some broken document links noted in #1036

@dasrecht dasrecht self-assigned this Apr 10, 2019
Copy link
Contributor

@dasrecht dasrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @akosmaroy - Thanks for your contribution!

I shortly tested it and the links seem to have been more broken than anticipated. You can adapt the links to link directly to the markdownfile.md#anchor

E.g. [`.lagoon.yml`](lagoon_yml.md#environmentsnamerollouts)

Feel free to update the PR and I'll merge it in after testing.

@dasrecht dasrecht added the 7-documentation-examples Documentation & Examples / DX subsystem label Apr 10, 2019
@akosmaroy
Copy link
Author

updated: removed './' prefix for local directory references, added '.md' postfix where it was missing

Copy link
Contributor

@dasrecht dasrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks a lot @akosmaroy

@dasrecht dasrecht merged commit af0d0d7 into uselagoon:master Apr 20, 2019
@Schnitzel Schnitzel added this to the v0.23.0 milestone May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-documentation-examples Documentation & Examples / DX subsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants