Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1028 support for WebP #1029

Merged
merged 2 commits into from
May 27, 2019
Merged

#1028 support for WebP #1029

merged 2 commits into from
May 27, 2019

Conversation

Schnitzel
Copy link
Contributor

No description provided.

@garethhallnz
Copy link
Contributor

I'd love to review the change and report back to here as to whether it fixed the issue or not, but I simply don't know how. What I mean to say is I am using FROM amazeeio/php:7.2-cli-drupal in my dockerfile but the change you have made is against the base image higher up the stack (obviously expected).

How would I test it and am I even required too? Happy to help out if I can.

garethhallnz
garethhallnz approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@garethhallnz garethhallnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run this locally and seems to work for me.

@cdchris12 cdchris12 mentioned this pull request May 16, 2019
Closed
@Schnitzel Schnitzel merged commit 417853a into master May 27, 2019
@Schnitzel Schnitzel added this to the v0.23.0 milestone May 27, 2019
@dasrecht dasrecht deleted the 1028-webp-support branch January 24, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethhallnz garethhallnz garethhallnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Schnitzel @garethhallnz @cdchris12