You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
AlexSkrypnyk
changed the title
Xdebug always enabled if XDEBUG_ENABLE has empty value
Xdebug always enabled if XDEBUG_ENABLE has empty value [has PR]
Aug 13, 2019
Describe the bug
Currently, the developer experience to enable Xdebug is to uncomment
the line
XDEBUG_ENABLE: true
indocker-compose.yml.
.This is annoying and not possible to set this variable on host (and automate it) like so in
docker-compose.yml
:This line
https://github.com/amazeeio/lagoon/blob/master/images/php/fpm/entrypoints/60-php-xdebug.sh#L29
uses
if [ ${XDEBUG_ENABLE+x} ];
, which evaluates to boolean true whenXDEBUG_ENABLE
env variable is set to empty.Proposed solution
Change the condition to check if
XDEBUG_ENABLE
variable value is empty instead of checking if the value is set.The text was updated successfully, but these errors were encountered: