Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Xdebug enabling when XDEBUG_ENABLE is not empty rather then not set. Closes 1170. #1174

Merged
merged 5 commits into from
Aug 28, 2019
Merged

Changed Xdebug enabling when XDEBUG_ENABLE is not empty rather then not set. Closes 1170. #1174

merged 5 commits into from
Aug 28, 2019

Conversation

AlexSkrypnyk
Copy link
Contributor

@AlexSkrypnyk AlexSkrypnyk commented Aug 9, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Changelog entry has been written

This PR allows to have XDEBUG_ENABLE: ${XDEBUG_ENABLE:-} in docker-compose.yml and pass XDEBUG_ENABLE value to docker-compose up without changing the contents of docker-compose.yml:

XDEBUG_ENABLE="true" docker-compose up

Please note that in whole codebase in comments it is recommended to use true as a value of XDEBUG_ENABLE, so this change should not have negative effect on existing projects.

Changelog Entry

Change - Xdebug will be enabled only if XDEBUG_ENABLE variable has a value (#1170).

Closing issues

#1170

@AlexSkrypnyk
Copy link
Contributor Author

@Schnitzel any chance to get this one before v1? The change is minimal, but the DX is greatly improved (no changed docker-compose.yml in git repo when Xdebug was enabled).

@Schnitzel
Copy link
Contributor

@alexdesignworks
yes, sorry. We're a bit behind with reviewing PRs, but my expectation is to get this in before or with 1.0.0

@Schnitzel Schnitzel added this to the 1.0.0 RBAC milestone Aug 16, 2019
@Schnitzel Schnitzel merged commit f3116b8 into uselagoon:master Aug 28, 2019
@AlexSkrypnyk AlexSkrypnyk deleted the 1170-xdebug-non-empty branch August 28, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants