Changed Xdebug enabling when XDEBUG_ENABLE is not empty rather then not set. Closes 1170. #1174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This PR allows to have
XDEBUG_ENABLE: ${XDEBUG_ENABLE:-}
indocker-compose.yml
and passXDEBUG_ENABLE
value todocker-compose up
without changing the contents ofdocker-compose.yml
:XDEBUG_ENABLE="true" docker-compose up
Please note that in whole codebase in comments it is recommended to use
true
as a value ofXDEBUG_ENABLE
, so this change should not have negative effect on existing projects.Changelog Entry
Change - Xdebug will be enabled only if
XDEBUG_ENABLE
variable has a value (#1170).Closing issues
#1170