Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Tag images with "prefix-latest" version. #1129

Closed
fago opened this issue Jun 26, 2019 · 3 comments · Fixed by #1131
Closed

Feature request: Tag images with "prefix-latest" version. #1129

fago opened this issue Jun 26, 2019 · 3 comments · Fixed by #1131

Comments

@fago
Copy link
Contributor

fago commented Jun 26, 2019

Describe the bug
At https://github.com/drunomics/devsetup-docker we are using ARGs to build images based upon versioned images. For automated CI runs that are using docker-compose we use fixed versions so tests do not fail over night, e.g. done here: https://github.com/drunomics/contentpool/blob/8.x-1.x/.travis.yml#L68 The same applies to the localdev environment, it should be manually updated, so we know it does not fail after image updates (as we had it before versioned images).

But then, for production hosting we want "latest" images to be used. However, that is currently hard to control by an environment variable like

COMPOSE_AMAZEEIO_VERSION=v0.22.1

since an empty variables leads to invalid version strings for images like

FROM amazeeio/solr:6.6-drupal-${COMPOSE_AMAZEEIO_VERSION}

since "6.6-drupal-" is not defined, only "6.6-drupal" is.

Could you make latest image tags available using a pattern that always have a "latest" version instead of the versions string?
e.g. provide solr:6.6-drupal-latest in addition to (or instead of ) solr:6.6-drupal

@fago
Copy link
Contributor Author

fago commented Jun 26, 2019

It's even worse since empty environment variables are not working with docker-compose - it results in errors during image building. Thus I had to define two additional environment variables to make it work

    COMPOSE_AMAZEEIO_VERSION_DRUPAL=drupal
    COMPOSE_AMAZEEIO_VERSION_FPM=fpm

see https://github.com/drunomics/devsetup-docker/pull/4/files

That's a quite a hassle since that additional required variables are a BC change for our devsetup.

@fago
Copy link
Contributor Author

fago commented Jul 3, 2019

the pushed -latest tags work fine, thank you! I guess we leave this open until the PR is closed.

@Schnitzel
Copy link
Contributor

@fago
yes it will be closed automatically as soon as the PR is merged

Schnitzel added a commit that referenced this issue Jul 12, 2019
@Schnitzel Schnitzel modified the milestones: v0.25.0, v1.0.0 RBAC Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants